Closed Bug 571636 Opened 14 years ago Closed 14 years ago

Search UI should follow a grid design

Categories

(Bugzilla :: User Interface, defect)

Product:
Bugzilla
Component:
User Interface
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.0

People

(Reporter: guy.pyrzak, Assigned: guy.pyrzak)

References

Details

Attachments

(1 file, 3 obsolete files)

v4
4.05 KB, patch
mkanat
: review+
Details | Diff | Splinter Review 
The new search UI doesn't follow a grid design and some of the labels are too close to the elements they represent. The CSS should be updated to make the UI follow a grid and therefore be easier to follow and look more organized.
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.8
Attached patch V1 (obsolete) — — Splinter Review 
Assignee: ui → guy.pyrzak

        Attachment #450801 -
        Flags: review?(mkanat)

    
  
Depends on: 450301

    
    

    
  
Comment on attachment 450801 [details] [diff] [review]
V1

Cool, I really like how the Summary search box looks now! :-) However, I'd like it even more if it could be centered relative to the 3/4 boxes below it.

I don't like the way the text-search boxes look in the Detailed Bug Information section. I much much prefer them to be single lines. I just want those single lines to line up with each other properly.

        Attachment #450801 -
        Flags: review?(mkanat) → review-

    
  
Flags: blocking4.0+

    
    

    
  
Ping. :-)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2 (obsolete)
        — 
          — Splinter Review
      

    


  
couldn't get the summary fix you wanted but did the other stuff.

        Attachment #450801 -
        Attachment is obsolete: true

        Attachment #465893 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 465893 [details] [diff] [review]
v2

The Deadline field looks weird now in Detailed Bug Information.

        Attachment #465893 -
        Flags: review?(mkanat) → review-

    
    

    
  
Oh, also, you may want to right-align the summary field label.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        V3 (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #465893 -
        Attachment is obsolete: true

        Attachment #466043 -
        Flags: review?(mkanat)

    
  

        Attachment #466043 -
        Attachment is patch: true

        Attachment #466043 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  
Comment on attachment 466043 [details] [diff] [review]
V3

The second Deadline box is still on a separate line, for me. Also, at least in Chrome, there's a slightly odd gap between the labels of the text fields and the drop-downs for the search-type selection. (I'm guessing that's from the margin-right: 2em" on the field_label span.)

        Attachment #466043 -
        Flags: review?(mkanat) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v4
        — 
          — Splinter Review
      

    


  

        Attachment #466043 -
        Attachment is obsolete: true

        Attachment #467154 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 467154 [details] [diff] [review]
v4

Looks faaaahbulous!! :-D

        Attachment #467154 -
        Flags: review?(mkanat) → review+

    
    

    
  
You're my hero, pyrzak. :-)
Flags: approval4.0+
Flags: approval+

    
    

    
  
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified skins/standard/search_form.css
modified template/en/default/search/field.html.tmpl
modified template/en/default/search/form.html.tmpl
Committed revision 7450.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified skins/standard/search_form.css
modified template/en/default/search/field.html.tmpl
modified template/en/default/search/form.html.tmpl
Committed revision 7386.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: