Closed Bug 572188 Opened 14 years ago Closed 14 years ago

Migrate Try to schedulerdb

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(2 files, 1 obsolete file)

      No description provided.
Attached patch Try configs for schedulerdb (obsolete) — Splinter Review
Attachment #451359 - Flags: review?(nrthomas)
Attachment #451359 - Flags: review?(lsblakk)
Comment on attachment 451359 [details] [diff] [review]
Try configs for schedulerdb


>-c['buildbotURL'] = 'http://production-master01.build.mozilla.org:8010/'
>+c['buildbotURL'] = 'http://production-master02.build.mozilla.org:8010/'
> 

looks good - the only question i have is about the urls - won't try be on 8011?
Attachment #451359 - Flags: review?(lsblakk) → review+
Attachment #451359 - Flags: review?(nrthomas) → review+
Comment on attachment 451359 [details] [diff] [review]
Try configs for schedulerdb

>diff --git a/mozilla/builder_master.cfg b/mozilla/builder_master.cfg
>+from config import BRANCHES, MAC_MINIS, XSERVES, MAC_SNOW_MINIS
>+from master_localconfig import ACTIVE_BRANCHES, SLAVES
> 
> L10N_SLAVES = {
>     'linux': SLAVES['linux'],
>     'linux64': SLAVES['linux64'],
>     'win32': SLAVES['win32'],
>     'macosx': MAC_MINIS + XSERVES,
>     'macosx64': MAC_SNOW_MINIS,
> }

This pattern appears in production_config.py too. Here in builder_master can we just set |L10N_SLAVES = SLAVES| and only import BRANCHES from config ?

>diff --git a/mozilla/production_config.py b/mozilla/production_config.py
>@@ -72,12 +86,32 @@ BRANCHES = {
>+    'tryserver': {
...
>+        'platforms': {
>+            'win32': {
>+                'env': {
>+                    'SYMBOL_SERVER_HOST': 'build.mozilla.org',
>+                    'CVS_RSH': 'ssh',
>+                    'MOZ_OBJDIR': 'obj-firefox',
>+                    'TINDERBOX_OUTPUT': '1',
>+                    'MOZ_CRASHREPORTER_NO_REPORT': '1',
>+                    # Source server support, bug 506702
>+                    'PDBSTR_PATH': '/c/Program Files/Debugging Tools for Windows/srcsrv/pdbstr.exe'
>+                },

Urgh, shame we have to duplicate config.py content here just to set SYMBOL_SERVER_HOST.

>diff --git a/mozilla/production_builder_master_pm01_localconfig.py b/mozilla/production_try_builder_master_pm02_localconfig.py

What Lukas said about the port on c['buildbotURL'] not matching.

> # Set up our fast slaves
> # No need to reload, this is reloaded by builder_master.cfg
> import buildbotcustom.misc
> buildbotcustom.misc.fastRegexes.extend([
>     '-ix-',
>     'xserve',
>     ])

This bit isn't needed but I see we're leaving them in staging too.
Blocks: 571571
Attached patch Refreshed patchSplinter Review
Carrying over r+
Attachment #451359 - Attachment is obsolete: true
Attachment #451645 - Flags: review+
Comment on attachment 451645 [details] [diff] [review]
Refreshed patch

2519:68ac0a9579f7
Attachment #451645 - Flags: checked-in+
Attachment #451967 - Flags: review?(bhearsum) → review+
Comment on attachment 451967 [details] [diff] [review]
Have sendchanges go to pm01:9009 (scheduelr master)

2529:b243c8a57258
Attachment #451967 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
No longer blocks: 571571
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: