572220 - "Tags" section is empty on the left hand side menu in some search results pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/en-GB/firefox/search/?q=%3D%3Fq&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=
2.Notice that "Tags" section is empty on the left hand side menu

Having an empty "Tags" section is not very useful.

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Krupa,

Would you be okay with me eliminating the Tags section?

There's no tags because for en-GB addons with tags... 

I could do some finagling and get tags to show up regardless of locale.

-d

Comment 2

[Jeff Balogh (:jbalogh)]

Wrapping it in {% if tags %} seems perfectly reasonable.

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> Wrapping it in {% if tags %} seems perfectly reasonable.

yeah, do this

Comment 4

[krupa raj[:krupa]]

(In reply to comment #1)
> Krupa,
> 
> Would you be okay with me eliminating the Tags section?
> 
> There's no tags because for en-GB addons with tags... 
> 
> I could do some finagling and get tags to show up regardless of locale.
> 
> -d

I would be fine with eliminating the tags section.Thanks.

(In reply to comment #1)
> Krupa,
> 
> Would you be okay with me eliminating the Tags section?
> 
> There's no tags because for en-GB addons with tags... 
> 
> I could do some finagling and get tags to show up regardless of locale.
> 
> -d

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/davedash/zamboni/compare/master...tag-filters-572220

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/6f2ebae

Comment 7

[krupa raj[:krupa]]

verified at 
https://preview.addons.mozilla.org/en-GB/firefox/search/?q=%29*%29j&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=

 
https://preview.addons.mozilla.org/en-GB/firefox/search/?q=%3D%3Fq&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=

https://preview.addons.mozilla.org/en-US/firefox/search/?q=jk&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=