572587 - Starring suggestions should highlight/bold the matching portion of the error messagae

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, enhancement)

Description

[Jesse Ruderman]

Starring suggestions key based on the test name.  To make it easier to tell whether it's the same failure (and not another failure in the same test), the matching part of the error message should be highlighted.

Would make it easier to tell that this *isn't* the correct bug:

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug356571.js | application timed out after 330 seconds with no output
    Bug 545584 - Intermittent failure in browser_bug356571.js | Correctly opened all expected tabs

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Highlight the matches in the bug summary, and give closed bugs more visibility by underlining the entire row.

See http://ehsanakhgari.org/tinderboxpushlog/index.html to see how it looks.

Comment 2

[(no longer active)]

Attachment: Patch (v1.1)

On second thought, using global and case insensitive match would probably give better highlighting results.

Comment 3

[(no longer active)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/013f50d410a4

Comment 4

[(no longer active)]

I pushed this as a followup to this bug, to fix the html code displaying inside summaries.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d412cccd5fb7

I'm not sure why this didn't happen on my instance, but my testing inside Firebug shows that it should fix the problem.

Comment 5

[Markus Stange [:mstange]]

I don't understand why this happened and why that fixed it. Deployed.

Comment 6

[(no longer active)]

(In reply to comment #5)
> I don't understand why this happened and why that fixed it. Deployed.

Well, we were basically replacing the empty string with span tags over and over again.  See bug 574516 for a similar problem.