572804 - Disabled optgroup handling of the form manager is buggy

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, with fennec I don't see the "optgroup title" text in the optgroup line.
Also, which you can see with the second select, the disabled attribute for the optgroup isn't obeyed for the form manager. Option 3 can be selected in Fennec.

Some other bugs, that I'm seeing:
- Option 4 of the second select can't be selected (which is correct, because it's disabled), but it looks like an ordinary option. It should look disabled.
- Shouldn't option3 of the second select be indented, since it's part of an optgroup?

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #0)
> Created attachment 452012 [details]
> testcase
> 
> See testcase, with fennec I don't see the "optgroup title" text in the optgroup
> line.
This should be fixed by bug 573561

> Also, which you can see with the second select, the disabled attribute for the
> optgroup isn't obeyed for the form manager. Option 3 can be selected in Fennec.
> 
> Some other bugs, that I'm seeing:
> - Option 4 of the second select can't be selected (which is correct, because
> it's disabled), but it looks like an ordinary option. It should look disabled.
> - Shouldn't option3 of the second select be indented, since it's part of an
> optgroup?

That's the main part of the bug, I've changed the title to reflect this.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This just change the color of a disabled item and prevent any mouse events on it.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/5cb8c1852a81

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010726 Namoroka/4.0b2pre Fennec/2.0a1pre

Comment 5

[Martijn Wargers (dead)]

I'm reassigning this to myself for adding litmus testcases for this (aakashd
discussed this on irc with blassey and ted on #mobile).