572823 - Clear open state on parent menu when popup is destroyed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: implement this

Otherwise, the open attribute can still be set even though the popup isn't there.

Comment 1

[[e-mail]]

Comment on attachment 452035 [details] [diff] [review]
implement this

Seems reasonable to me, although should it check that the attribute exists before adding a runnable?

Side note: what should happen if nsMenuFrame::PopupOpened finds that it's been destroyed?

Comment 2

[Neil Deakin]

(In reply to comment #1)
> (From update of attachment 452035 [details] [diff] [review])
> Seems reasonable to me, although should it check that the attribute exists
> before adding a runnable?

I'll add this check.

> Side note: what should happen if nsMenuFrame::PopupOpened finds that it's been
> destroyed?

Which situation where you thinking of?

Comment 3

[[e-mail]]

nsMenuFrame::PopupOpened sets the open attribute, but if it finds out that it's been destroyed then it simply returns; should it try to unset the attribute?

Comment 4

[Neil Deakin]

Clearing the open attribute during nsMenuFrame::DestroyFrom would seem reasonable as well. Currently only menuactive is cleared.

Comment 5

[Neil Deakin]

Actually, as this patch clears the open state when the panel is destroyed, the issue in comment 3 is already accounted for.

Comment 6

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/21585954d812