Closed Bug 572867 Opened 14 years ago Closed 14 years ago

performance runtests: have a more succinct two-vm output mode

Categories

(Tamarin Graveyard :: Tools, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Q3 11 - Serrano

People

(Reporter: cpeyer, Assigned: cpeyer)

References

Details

Attachments

(1 file, 1 obsolete file)

from edwin:
to view the results of a two-VM, multiple-iteration run, you need 170 columns.  this makes it difficult to communicate about results (email & bugzilla unfriendly text formatting)
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Target Milestone: --- → flash10.2
Clean up output for runtests.  New class var testFieldLen sets the amount of columns to allow for the testname - currently is not editable but would be very easy to add a commandline param.  Also includes some code cleanup in areas that I was editing.
Attachment #453524 - Flags: review?(brbaker)
Attachment #453524 - Flags: feedback?(edwsmith)
Attachment #453524 - Attachment is obsolete: true
Attachment #454064 - Flags: review?(brbaker)
Attachment #454064 - Flags: feedback?(edwsmith)
Attachment #453524 - Flags: review?(brbaker)
Attachment #453524 - Flags: feedback?(edwsmith)
Attachment #453524 - Flags: review+
Attachment #454064 - Flags: review?(brbaker) → review+
pushed to redux: http://hg.mozilla.org/tamarin-redux/rev/c705f998093b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment on attachment 454064 [details] [diff] [review]
minor update to make patch apply properly

The output looks nice.


    Note that %diff is calculated using the fastest value (not avg) of all runs

                                     avm:0         avm2:0
    test                             best    avg   best    avg  %diff  sig
    Metric: v8 (largerValuesFaster)
    v8.5/untyped/raytrace.as         1802 1796.9   1788 1798.7    0.1  0.2   
    v8.5/untyped/deltablue.as        1000  990.2    986  995.0    0.3  0.3   

Is the comment about fastest vs avg still correct?  in the two examples above, best went down, avg went up, and %diff is positive.  Also might be good for the note to say "best" instead of "fastest".
Attachment #454064 - Flags: feedback?(edwsmith) → feedback+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: