572960 - Only run the InstallTrigger callback on success

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Jeff Balogh (:jbalogh)]

Thus spoke Mossop:

The callback function gets passed two arguments. First is the url of the xpi it is calling for, second is a status code: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/addonManager.js#52

You probably only want to redirect if the status was 0.

Comment 1

[Wil Clouser [:clouserw]]

-> potch, r? jbalogh since he likes the buttons so much

Comment 2

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/02977f3c

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

What's the best way to verify this?  With Firebug, I'm guessing, but how?

Comment 4

[Jeff Balogh (:jbalogh)]

1. Find an addon that redirects to contributions after installation.
2. Install it and see that you are redirected.
3. Uninstall.
4. Click add to firefox but cancel installation.  You should not be redirected and there should be no js errors.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I cancelled installation through the Add-ons Manager, and was redirected to https://preview.addons.mozilla.org/z/en-US/firefox/addon/25/developers; reopening.

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> I cancelled installation through the Add-ons Manager, and was redirected to
> https://preview.addons.mozilla.org/z/en-US/firefox/addon/25/developers;
> reopening.

Wrong kind of cancel.  I'm talking about cancelling after the 3-second countdown.  Once it's in about:addons we're totally disconnected.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Potch/Jeff: re-close at will, sires!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; apologies for the snafu.