573187 - Test Pilot is downloading multiple copies of the same jar files

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Jono Xia]

In fact, I have 96 copies of the same jar file in my TestPilotExperimentFiles directory.  Named week-life-1.jar, week-life-2.jar, all the way up to week-life-96.jar.

This is a Bad Thing.

Evidently the code that tries to detect whether the file has changed before downloading it isn't working, and it's downloading every time.  Also, apparently when it saves a new version, it doesn't overwrite the previous version, but actually changes the name to avoid the conflict.  So we need to fix the logic of dont-download-unless-changed, and if it has changed we need to delete the old one before saving the new one.

Comment 1

[Jono Xia]

The failure of the If-Modified-Since logic is a direct result of the newly downloaded file not overwriting the original: the original "week-life.jar" remains unmodified, and its modification date is the one used for the "If-Modified-Since" header... the newly downloaded one becomes "week-life-1.jar" which means that no matter how many times it downloads "week-life.jar", the modification date of "week-life.jar" never changes.

Comment 2

[Jono Xia]

This line of code was the culprit:

jarFile.createUnique( Ci.nsIFile.NORMAL_FILE_TYPE, 600);

Of course, if I tell it to createUnique, it creates a unique file!  Duh.

Comment 3

[Jono Xia]

Fixed in http://hg.mozilla.org/labs/testpilot/rev/7dece2556926