573636 - add jdk6/bin to the step's PATH environment to workaround a make issue

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Taylor [:bear]]

Attachment: add jdk6 bin/ to PATH for compile step

add to the compile step's environment PATH value the /tools/jdk6/bin path to allow the SUTAgent build to work until they fix their issue

Comment 1

[Aki Sasaki (not active)]

Comment on attachment 452914 [details] [diff] [review]
add jdk6 bin/ to PATH for compile step

wish i knew why java_home wasn't working, but i'm not going to block builds on that.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 452914 [details] [diff] [review]
add jdk6 bin/ to PATH for compile step

http://hg.mozilla.org/build/buildbotcustom/rev/3d93f905a060

Comment 3

[Mike Taylor [:bear]]

Attachment: seems you do need a default param for the get() call for path

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 452964 [details] [diff] [review]
seems you do need a default param for the get() call for path

>-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
>+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', os.environ['PATH'])

while we use the same ref image for the slave and master, we should not be pulling the environment of the master to set up the environment of the slave.  Instead, could we set the path explicitly in mobile_config.py?

Comment 5

[Mike Taylor [:bear]]

Attachment: seems you do need a default param for the get() call for path

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 452972 [details] [diff] [review]
seems you do need a default param for the get() call for path

>-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
>+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin'])

Assuming that bin']) should have been bin').  If that is the case, will land with this :)

Comment 7

[Mike Taylor [:bear]]

(In reply to comment #6)
> (From update of attachment 452972 [details] [diff] [review])
> >-        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH')
> >+        envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin'])
> 
> Assuming that bin']) should have been bin').  If that is the case, will land
> with this :)

yes, was too busy arguing with you to notice the errant key - thanks

Comment 8

[Aki Sasaki (not active)]

Resolved?

Comment 9

[Mike Taylor [:bear]]

yes