573733 - Rename mTabs to tabs in suite tabbrowser

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Robert Kaiser]

Firefox uses gBrowser.tabs, even the mochitest-browser-chrome harness uses that, and we also already use .mTabs outside of tabbrowser, which suggestes it should not have the m prefix that pretends to be internal.

Comment 1

[Robert Kaiser]

Attachment: v1: rename all occurrences, add compatibility shim

This should rename all our internal uses, and just as Firefox, adds a <property> for backwards compat.

Comment 2

[[e-mail]]

Comment on attachment 453065 [details] [diff] [review]
v1: rename all occurrences, add compatibility shim

>     var tabs = [];
>-    var mTabs = this._tabbrowser.mTabs;
>+    var mTabs = this._tabbrowser.tabs;
That's confusing variable naming :-(

Comment 3

[Robert Kaiser]

(In reply to comment #2)
> (From update of attachment 453065 [details] [diff] [review])
> >     var tabs = [];
> >-    var mTabs = this._tabbrowser.mTabs;
> >+    var mTabs = this._tabbrowser.tabs;
> That's confusing variable naming :-(

Switched to tabNodes per IRC discussion and pushed as http://hg.mozilla.org/comm-central/rev/a9126328c4a9