573740 - Register resource://services-sync before xpcshell tests get run

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Seems like app-startup notification isn't sent.. or is sent after the xpcshell test tries to run.

We'll have to add the resource earlier.. maybe in the Weave.js's WeaveService constructor.

Or register it from the test head_

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/94d14dc51035
Add the alias to resource://services-sync when loading the component instead of waiting for app-startup, which doesn't fire for xpcshell tests.

Comment 3

[Philipp von Weitershausen [:philikon]]

Comment on attachment 453161 [details] [diff] [review]
v1

>+(function addResourceAlias() {
>+  let ioService = Cc["@mozilla.org/network/io-service;1"].
>+                  getService(Ci.nsIIOService);
>+  let resProt = ioService.getProtocolHandler("resource").
>+                QueryInterface(Ci.nsIResProtocolHandler);
>+
>+  // Only create alias if resource://services-sync doesn't already exist.
>+  if (resProt.hasSubstitution("services-sync"))
>+    return;

While fixing the test issue on the trunk, this patch causes problems for the add-on case: the aliasing now happens when the top scope of Weave.js is executed. This apparently happens *before* the add-on's chrome.manifest is registered so the above if never triggers on the add-on.

I suggest backing this out and doing the aliasing separately for the tests.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: Fix add-on case

Put the call to addResourceAlias() back into the app-startup observer, but expose addResourceAlias() to other JS contexts so we can call it from xpcshell tests.

Comment 5

[Ed Lee :Mardak]

(In reply to comment #3)
> This apparently happens *before* the add-on's chrome.manifest is
> registered so the above if never triggers on the add-on.
Hrm. There must be a difference between cached manifests then. Seems like the add-on passes tests fine for existing profiles.

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/26b413905024
Don't try to create the alias too early, add-on chrome registration might not have happened yet, so do it during testing.