573815 - Flashblock does not display play button on Dailymotion videos

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Pierre Rudloff]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9.0.19) Gecko/2010051911 Camino/2.0.3 (MultiLang) (like Firefox/3.0.19)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9.0.19) Gecko/2010051911 Camino/2.0.3 (MultiLang) (like Firefox/3.0.19)

There is no Flashblock play button on Dailymotion flash videos. A click still launch the video though.

Reproducible: Always

Steps to Reproduce:
1.Activate Flashblock
2.Go to dailymotion.com
3.Click on any video

Actual Results:  
The video block is empty.

Expected Results:  
There should be a play button.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please contact the developers of Flashblock about the problem: http://flashblock.mozdev.org/

As this big is not about a product, web site or service owned or maintained by Mozilla, I close the bug as Resolved Invalid.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Please don't close Camino bugs unless you're a Camino developer.

Comment 3

[philippe (part-time)]

The same happens with a recent Minefield nightly.

The button overlay (which is a background-image actually), is killed by this:

body.dm_page_html_video div#top_content_box div.dmpi_video_playerv4 div {
background:none repeat scroll 0 0 transparent !important;
}
http://ak.style.dailymotion.com/css/gen/widget/pack/baseskin-prod.css.v119801261

Comment 4

[Philip Chee]

Attachment: flashblock.xml: Use !important for our backbround images

> The button overlay (which is a background-image actually), is killed by this:
> 
> body.dm_page_html_video div#top_content_box div.dmpi_video_playerv4 div {
> background:none repeat scroll 0 0 transparent !important;
> }
The attached flashblock.xml sets the !important flag on the background images. Tested on Minefield.

Comment 5

[Philip Chee]

Not sure who your normal reviewers are. Please set as appropriate.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 453380 [details]
flashblock.xml: Use !important for our backbround images

philippe, can I have you take this for a spin?  You're probably the Camino person most likely to notice any unintended side effects…

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And Philip, thanks for the quick fix yet again!

Comment 8

[philippe (part-time)]

Comment on attachment 453380 [details]
flashblock.xml: Use !important for our backbround images

This does the trick for dailymotion. I went to a bunch of flash filled sites, from youtube to your grandmother's blog without noticing any (display) issues.

(I didn't try myspace.com :-))

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Part 1: Upgrade to Flashblock 1.5.13

While getting Philip's changes into a patch, I realized we seem to have missed an upgrade to Flashblock 1.5.13.  Rather than lump everything into one patch/commit (which is probably OK here, but it offends my sense of order :P), this patch first upgrades us to Flashblock 1.5.13 (changes to the .xml, the .css, and our README; note the deleted "contents.rdf" stuff still applies to 1.9.0-based branches, so that will differ across branches).

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Part 2: Upgrade to latest flashblock.xml from Philip Chee

This is Philip's flashblock.xml above plus our README change.  I called it "flashblock-unstable.xpi plus the fix for bug 573815" because the fix here 1) is not yet available in the unstable.xpi (but it might be before we land this, I suppose) and 2) because there are other changes beyond 1.5.13 also present.

For the sake of completeness, I'll also attach a hacked-up (do not try to apply, do not review) diff that shows just the changes between -unstable and the above .xml (i.e., just the hunks that are changes to fix this bug), but I only intend to land in two parts: 1.5.13 and latest-flashblock.xml.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: For reference only: just the changes that fix this bug

As mentioned above, this is the hack-diff that shows just the changes made to flashblock.xml to fix this bug (not for review/applying/landing).

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Er, that should be "flashblock-1.5.unstable.xpi" in the README in Part 2; I'll fix that before landing.

Comment 13

[Stuart Morgan]

Comment on attachment 453615 [details] [diff] [review]
Part 1: Upgrade to Flashblock 1.5.13

sr=smorgan x2

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/b1906107efdc
http://hg.mozilla.org/camino/rev/6d411536d7dc

Thanks again for the quick fix, Philip!

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Also on CVS trunk and CAMINO_2_0_BRANCH.