574639 - Several fixes for configure.in and rules.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

1) Fix flags for gcc compiler on Solaris
2) Move Sun Studio specific options from rules.mk to configure.in
also add -D__FUNCTION__=__func__ for CFLAGS.
Used in harfbuzz.
3) Add option "-xannotate=no" for Sun Studio 12.1 (Sun C++ 5.10)
It is required on latest OpenSolaris.
4) Support for VPX_X86_ASM

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/5b2b66e6c761
http://hg.mozilla.org/mozilla-central/rev/f892729bce41

http://hg.mozilla.org/comm-central/rev/a63c725f626d

Comment 3

[Justin Wood (:Callek)]

Ginn, I'm not opposed to this c-c change, but in the future could you please request review from a c-c build peer for a c-c portion.

The primary reason is that c-c has some divergence from m-c for build system. (We're behind in some cases for one; and for two, there are many patches that need mozilla/ added to the stuff as we don't copy EVERY file that we use).

I am a reviewer for the c-c side of things, and can promise fast reviews especially if the patch ALREADY has a m-c review+