575097 - New STS header in Bugzilla::CGI causes malformed header error due to lack of Content-Type naming

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

I cannot display any bug. landfill displays the source code, and my local installation simply crashes with:

malformed header from script. Bad header=Text/html: show_bug.cgi

mkanat suspects this is due to the STS bug.

Comment 1

[Frédéric Buclin]

OK, it's definitely a regression due to the STS bug. Backing out the patch fixes the problem (which I'm going to do if this bug is not fixed quickly).

Comment 2

[Reed Loden [:reed]]

From `perldoc CGI`:
       Several routines are commonly called with just one argument.  In the case of these routines you can provide the
       single argument without an argument name.  header() happens to be one of these routines.  In this case, the
       single argument is the document type.

          print $q->header('text/html');

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v1

Always give the Content-Type header a name, not just in the case of cookies existing.

Comment 4

[Frédéric Buclin]

Comment on attachment 454376 [details] [diff] [review]
patch - v1

This fixes the problem. r=LpSolit

Comment 5

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/CGI.pm
Committed revision 7254.