Closed
Bug 575443
Opened 14 years ago
Closed 13 years ago
use an existing makedirs function
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
(Whiteboard: [mozmill-2.0+])
Attachments
(1 file)
|
3.85 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
makedirs is redefined in mozrunner: http://github.com/mozautomation/mozmill/blob/master/mozrunner/mozrunner/__init__.py#L148 instead, os.makedirs may be used
|
Reporter | |
Updated•14 years ago
|
OS: Linux → All
Hardware: x86 → All
Whiteboard: [mozmill-2.0?]
|
|
Reporter | |
Comment 1•14 years ago
|
||
works for linux. untested on mac + win
Attachment #501509 -
Flags: review?(fayearthur+bugs)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 501509 [details] [diff] [review] remove hand-rolled makedirs function works on Mac too.
Attachment #501509 -
Flags: review?(fayearthur+bugs) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
pushed to master: https://github.com/mozautomation/mozmill/commit/b2a88695c8bda91f02456ad110205507d49e45c7 There has been some talk that os.makedirs does not work for some cases. Of course, this is impossible to tell since there is no comment to that affect. If there is a reason to revert, we can revert or use e.g. distutils.dir_util.create_tree . If we do add it back in, we should have at least a comment and preferably a test and it should probably be rewritten in a more reasonable manner (with, again, any subtleties documented)
|
|
Reporter | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•