Closed
Bug 575657
Opened 14 years ago
Closed 14 years ago
[e10s] TabChild should use NS_NOTREACHED in addition to NS_ERROR_NOT_IMPLEMENTED
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | - | --- |
People
(Reporter: dougt, Assigned: MikeK)
References
Details
Attachments
(1 file)
|
4.20 KB,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
>+++ b/dom/ipc/TabChild.cpp
There are a lot of NS_ERROR_NOT_IMPLEMENTED methods here. Are they expected to
not be called? Should they have NS_NOTREACHED in them?
|
||
Updated•14 years ago
|
tracking-fennec: --- → ?
|
Assignee | |
Comment 2•14 years ago
|
||
Waiting for some test to complete before asking for review on this one...
Assignee: nobody → mkristoffersen
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Attachment #485037 -
Flags: review?(doug.turner)
|
Reporter | |
Updated•14 years ago
|
Attachment #485037 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 485037 [details] [diff] [review] Added a lot of NS_NOTREACHED low risk. fallout from the e10s->merge
Attachment #485037 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•14 years ago
|
||
Try server seems ok with this change
|
|
Assignee | |
Comment 6•14 years ago
|
||
Pushed as: http://hg.mozilla.org/mozilla-central/rev/f3f9c6b6e30a
You need to log in
before you can comment on or make changes to this bug.
Description
•