Closed Bug 575934 Opened 14 years ago Closed 14 years ago

Give the buttons in the customization panel a button style

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b3

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
Here are the Mac style changes that we wanted bug 573326 for. They're not pretty; any better ideas?
Attachment #455104 - Flags: review?(dao)
Summary: Give the buttons in the customization a button style → Give the buttons in the customization panel a button style
Could we remove toolbar[mode="icons"] and fix up text and text+icons mode separately?

Another option might be to replace <hbox class="paletteRow"> with <toolbar mode="icons" class="paletteRow">.
(In reply to comment #1)
> Could we remove toolbar[mode="icons"] and fix up text and text+icons mode
> separately?

Sounds good, I'll do that.

> Another option might be to replace <hbox class="paletteRow"> with <toolbar
> mode="icons" class="paletteRow">.

Ugh.
Attachment #455104 - Flags: review?(dao)
Attached patch v2Splinter Review
Attachment #455104 - Attachment is obsolete: true
Attachment #459359 - Flags: review?(dao)
Attachment #459359 - Flags: review?(dao) → review+
Attachment #459359 - Flags: approval2.0?
Comment on attachment 459359 [details] [diff] [review]
v2

a=me
Attachment #459359 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/18a809b713d2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: