576599 - add support for android running multiple threads per device

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Dan Schaffer]

froyo support concurrency.  experiment with using 2+ threads per phone on android to see if the time is faster.   

especially with the n1 we may be able to make big speedup especially with a single phone to run with 2 or 3 threads.  the patch is an offshoot of 575777: supporting multiple phones.

Comment 1

[Dan Schaffer]

Attachment: patch for mult threads per phone

experimental patch, still testing, wanted to save patch during July shutdown

Comment 2

[Dan Schaffer]

Attachment: patch to add android threads

Comment 3

[Brent Baker]

Comment on attachment 457914 [details] [diff] [review]
patch to add android threads

I have a couple tweaks to this patch which I will post shortly

Comment 4

[Brent Baker]

Attachment: v2. add android threading and cleanup code

This adds a little more cleanup code for restarting adb server and cleans up and displays and rogue adb processes.

Chris can you take a look at this in Dan's absence, I have pushed it through the sandbox a couple of times and has been clean.

Comment 5

[Brent Baker]

Comment on attachment 458670 [details] [diff] [review]
v2. add android threading and cleanup code

patch pushed as 4919:7ba01b2fa39c

Comment 6

[Brent Baker]

Attachment: more tweaks to how we communicate with adb

- reboot the android devices during setup to ensure that the devices
  are in a clean state
- make sure that all devices have been rooted
- only determine the devices that are connected to the machine in
  android_shell.py if it is actually needed
- use a file object instead of PIPE when running the abc file. We have
  seen issues where adb and the python script will end up blocked when
  the stdout is _large_, this appears to have fixed the instability
  issues that we were seeing with android acceptance runs

Comment 7

[Brent Baker]

Comment on attachment 460604 [details] [diff] [review]
more tweaks to how we communicate with adb

patch pushed as 4931:5bd7d99ab6ba

Comment 8

[Brent Baker]

Attachment: echo contents of adb_failures into stdio

Clean up the adb_failures log file and also echo the contents of the file into the buildbot stdio for the run so that it can be seen without having to log onto the machine

Comment 9

[Brent Baker]

Comment on attachment 460872 [details] [diff] [review]
echo contents of adb_failures into stdio

patch pushed as 4959:a21062dff942

Comment 10

[Brent Baker]

Marking this bug as fixed. Tracking additional 'adb' issues via bug #583022