Closed Bug 576885 Opened 14 years ago Closed 14 years ago

AIX compilation error in media/libvorbis/lib

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Version:
1.9.1 Branch
Platform:
PowerPC
AIX
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- .9-fixed
status1.9.1 --- .12-fixed

People

(Reporter: ul-mcamafia, Assigned: ul-mcamafia)

References

Details

(Keywords: verified1.9.1, verified1.9.2)

Attachments

(1 file)

Fixes AIX compilation errors for branches 1.9.1 and 1.9.2
438 bytes, patch
cajbir
: review+
dveditz
: approval1.9.2.9+
dveditz
: approval1.9.1.12+
Details | Diff | Splinter Review 
Missing flag for alloca()
Assignee: nobody → ul.mcamafia
Patch for branches 1.9.1 and 1.9.2 only
Attachment #455971 - Flags: review?(chris.double)
Status: NEW → ASSIGNED
Blocks: 576887
Attachment #455971 - Attachment description: Fixes AIX compilation errors for branches 1.9.1 and 1.9.2 → Fixes AIX compilation errors for branches 1.9.1 and 1.9.2
Attachment #455971 - Flags: review?(chris.double) → review+
Comment on attachment 455971 [details] [diff] [review]
Fixes AIX compilation errors for branches 1.9.1 and 1.9.2

Risc: None, only for AIX an additional compiler flag is appended.
Attachment #455971 - Flags: approval1.9.2.8?
Attachment #455971 - Flags: approval1.9.1.12?
Comment on attachment 455971 [details] [diff] [review]
Fixes AIX compilation errors for branches 1.9.1 and 1.9.2

Approved for 1.9.2.9 and 1.9.1.12, a=dveditz for release-drivers
Attachment #455971 - Flags: approval1.9.2.9?
Attachment #455971 - Flags: approval1.9.2.9+
Attachment #455971 - Flags: approval1.9.1.12?
Attachment #455971 - Flags: approval1.9.1.12+
Keywords: checkin-needed
Whiteboard: [checkin to branch 1.9.1], [checkin to branch 1.9.2]
Hmmm, there is a little conflict with the fixes of Bug 533822
in branch 1.9.2 update.sh and README_MOZILLA files. So I will adjust/recreate the patch for branch 1.9.2. The patched sources itself have cleanly applied.
Ignore comment #4, belongs to different bug. Sorry
This appears to be a branch-only bug -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin to branch 1.9.1], [checkin to branch 1.9.2]
Verified on AIX for the affected branches 1.9.1 and 1.9.2
Keywords: verified1.9.1, verified1.9.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: