576962 - console log/info etc. does handle multiple arguments + newline (\n)

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Viereck]

The console functions like console.log or console.info can take more then one argument. Also, a string passed to these functions containing a newline character (\n) should cause a new line in the console output.

This is not supported yet.

Comment 1

[Julian Viereck]

Attachment: Patch including unit tests.

Comment 2

[Julian Viereck]

Attachment: added a jsterm property on the HeadsUpDisplay

Required patch for running later unit tests.

Comment 3

[Julian Viereck]

Attachment: Final Patch

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 457547 [details] [diff] [review]
Final Patch


>+  let HUD = HUDService.hudWeakReferences[hudId].get();
>+  let jsterm = HUD.jsterm;
>+  let outputLogNode = jsterm.outputNode;
>+  ok(/foo bar/.test(outputLogNode.childNodes[0].childNodes[0].nodeValue),
>+                                              "Emitted both console arguments");

wonky indent.

r=me otherwise.

Comment 5

[Julian Viereck]

(In reply to comment #4)
> Comment on attachment 457547 [details] [diff] [review]

> >+  ok(/foo bar/.test(outputLogNode.childNodes[0].childNodes[0].nodeValue),
> >+                                              "Emitted both console arguments");
> 
> wonky indent.
> 
> r=me otherwise.

What is the right version?

  ok(/foo bar/.test(outputLogNode.childNodes[0].childNodes[0].nodeValue),
     "Emitted both console arguments");

indent to the open bracket ?

Comment 6

[Rob Campbell [:rc] (:robcee)]

yeah, or even just a single indent...

Comment 7

[Julian Viereck]

Attachment: [checked-in] Final Patch v2

Same as 457547 but fixed indention as required by reviewer.

Note: needs patch from bug 579073 applied.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457669 [details] [diff] [review]
[checked-in] Final Patch v2

changeset:   47817:f120e7e60a16
user:        Julian Viereck <[e-mail]>
date:        Fri Jul 16 12:00:53 2010 -0300
summary:     bug 576962 - console log/info etc. does handle multiple arguments + newline, r=dietrich