Closed
Bug 577002
Opened 14 years ago
Closed 13 years ago
Remove nsICSSImportRule
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: craig.topper, Assigned: craig.topper)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 4 obsolete files)
|
8.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
22.92 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
3.83 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Only implemented by one class and doesn't need to exist.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #456078 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #456080 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #456081 -
Flags: review?(dbaron)
|
||
Comment 4•14 years ago
|
||
FWIW, I'd probably use mozilla::css::ImportRule (CSSImportRule?) instead.
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Comment 5•14 years ago
|
||
Changed which header file I moved DECL_STYLE_RULE_INHERIT to.
Attachment #456794 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #456794 -
Attachment description: 456080: Part 2: Remove nsICSSImportRule and move nsCSSImportRule to header with a small change → Part 2: Remove nsICSSImportRule and move nsCSSImportRule to header with a small change
|
|
Assignee | |
Updated•14 years ago
|
Attachment #456080 -
Attachment is obsolete: true
Attachment #456080 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #456078 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #456081 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #456794 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #456078 -
Attachment is obsolete: true
Attachment #518979 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #456794 -
Attachment is obsolete: true
Attachment #518981 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 8•13 years ago
|
||
Attachment #456081 -
Attachment is obsolete: true
Attachment #518982 -
Flags: review?(bzbarsky)
|
||
Comment 9•13 years ago
|
||
Comment on attachment 518979 [details] [diff] [review] Part 1: Rename CSSImportRuleImpl r=me
Attachment #518979 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 10•13 years ago
|
||
Comment on attachment 518981 [details] [diff] [review] Part 2: Remove nsICSSImportRule r=me though again we should consider getting rid of the NS_New method there and just making the ctor take the right arguments (and possibly eliminating the url setter?). Also, I assume you checked that trying to QueryObject to css:ImportRule fails to compile? If not, we need to make it do sane things, right?
Attachment #518981 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 11•13 years ago
|
||
Comment on attachment 518982 [details] [diff] [review] Part 3: Remove virtual and cleanup some return types r=me
Attachment #518982 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 12•13 years ago
|
||
Pushed:
http://hg.mozilla.org/projects/birch/rev/ecf6c47436b6
http://hg.mozilla.org/projects/birch/rev/9ce52762e87a
http://hg.mozilla.org/projects/birch/rev/5de818f2b992Whiteboard: fixed-in-birch
https://hg.mozilla.org/mozilla-central/rev/ecf6c47436b6 https://hg.mozilla.org/mozilla-central/rev/9ce52762e87a https://hg.mozilla.org/mozilla-central/rev/5de818f2b992
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Priority: -- → P4
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
Depends on: 645951
You need to log in
before you can comment on or make changes to this bug.
Description
•