57741 - Wrapper scripts should propogate exit codes

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Raja Harinath]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.12-20smp i686; en-US; m18) Gecko/20001023
BuildID:    2000102308

The wrapper scripts 'mozilla' and 'run-mozilla.sh' do not propogate
the exit code of the wrapped program (e.g. mozilla-bin).  This
prevents, say automatic respawn script that try to restart Mozilla
if it crashed for some reason (e.g., if it exited with Sig11, the
exit code would be 139 -- indicating that it was an unasked-for exit).


Reproducible: Always
Steps to Reproduce:


Actual Results:

Expected Results:

A patch will be attached to the created bug.

Comment 1

[Raja Harinath]

Attachment: Propogate exit codes in wrapper scripts

Comment 2

[Doron Rosenberg (IBM)]

what file are you patching exactly? 

Comment 3

[Raja Harinath]

The patch applies to the scripts 'mozilla' and 'run-mozilla.sh' that are in the
distributed tarball.  Since I don't have a checked out tree, I don't know where
they are in the build tree.  

Also, the names of the files aren't clear in the patch.  Here's the relevant
part of the patch:

  --- mozilla~    Fri Jun 16 19:54:07 2000
  +++ mozilla     Mon Oct 23 17:42:08 2000
[snip]
  --- run-mozilla.sh~     Thu Sep 14 15:58:56 2000
  +++ run-mozilla.sh      Mon Oct 23 17:43:52 2000

If you want me to, I can check out a copy of the mozilla development tree and
create a new patch (but I would prefer not to, it takes up too much space ;-).

Comment 4

[Richard Waid]

Patch looks as though it should work (untested). Marking New.

Reassigning component to XP-Apps: Cmd-line Features.

Comment 5

[Doron Rosenberg (IBM)]

buildconfig

cc: granrose and leaf, our build people, and ramiro, who seems to be the owener
of run-mozilla.sh

Comment 6

[Doron Rosenberg (IBM)]

cc cls, as per granrose.

Comment 7

[cls]

Patch has been checked in.

Comment 8

[Jon Granrose]

verified fixed.