Closed
Bug 577872
Opened 14 years ago
Closed 13 years ago
Create WebM versions of Ogg reftests
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: kinetik, Assigned: padenot)
Details
(Whiteboard: [inbound])
Attachments
(1 file, 2 obsolete files)
38.07 KB,
patch
|
Details | Diff | Splinter Review |
We have no reftest coverage for WebM right now, and we need it.
Assignee | ||
Comment 1•13 years ago
|
||
How these would be different from the ogg reftests ? Could this be achieved using a few sed and ffmpeg invocations ?
Comment 2•13 years ago
|
||
WebM reftests would test the WebM decoder backend. You should be able to just convert the Ogg files used by the ogg reftests to WebM using ffmpeg, and create new tests for them identical to the existing Ogg reftests.
Assignee | ||
Comment 3•13 years ago
|
||
It appears that offset-1.xhtml fails with the webm backend. It is related to video cropping, and I don't know if this is supported in the webm format, since all my video players and browsers don't crop the video (as they do using the ogg version of the file). I've consequently removed that test in this patch, which is basically a |sed -i 's/\(.*\)ogv/\1webm/g' *html| invocation followed by a couple of ffmpeg call.
Comment 4•13 years ago
|
||
(In reply to comment #3) > It appears that offset-1.xhtml fails with the webm backend. It is related to > video cropping, and I don't know if this is supported in the webm format, It is, but the crop rectangle must be specified at the container level, and not the codec level like it is with Theora. I would not be surprised if whatever you used to do the conversion didn't preserve it correctly.
Assignee | ||
Comment 5•13 years ago
|
||
I finally managed to get an offset reftest working, so the suite is now as complete as the ogg testsuite. I used mkvmerge --cropping 1:29,4,6,31 --display-dimension 1:29x29 to get a correct video.
Attachment #547684 -
Attachment is obsolete: true
Attachment #547745 -
Flags: review?(kinetik)
Attachment #547684 -
Flags: review?(kinetik)
Reporter | ||
Updated•13 years ago
|
Attachment #547745 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 6•13 years ago
|
||
kinetik, several of these tests are failing on OSX 64bit. I've set up a mac today to try to reproduce the failure, but I haven't been successful so far. I plan to investigate tomorrow. try push : http://tbpl.mozilla.org/?tree=Try&rev=01e26493cec8
Reporter | ||
Comment 7•13 years ago
|
||
Paul, can you please remove poster-14.html before you check in? It's an invalid test; see bug 622059.
Assignee | ||
Comment 8•13 years ago
|
||
Here is the same patch without the test mentioned in the previous comment.
Attachment #547745 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [inbound]
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d108ca6c87fd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•