Closed
Bug 577910
Opened 14 years ago
Closed 13 years ago
mark DEBUG only variables as ifdef DEBUG in jsd
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file, 1 obsolete file)
|
927 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
this is part of a crusade to get rid of compilation warnings
|
||
Updated•14 years ago
|
Attachment #456737 -
Flags: review?(cbiesinger) → review+
|
|
||
Comment 2•14 years ago
|
||
I'm not really a jsd peer though...
Attachment #456737 -
Attachment is obsolete: true
Attachment #463497 -
Flags: review+
Summary: use NS_DEBUG_ASSIGN for jsd → mark DEBUG only variables as ifdef DEBUG in jsd
Attachment #463497 -
Flags: approval2.0?
|
||
Updated•13 years ago
|
Attachment #463497 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Comment on attachment 463497 [details] [diff] [review] using #ifdef DEBUG Removing approval - this has been sitting since August. Renominate if someone can show me that this hasn't bitrotten and is still needed.
Attachment #463497 -
Flags: approval2.0+
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
beltzner: i'm the module owner. it applied as of the last time i did a qrefresh to my queue: http://hg.mozilla.org/users/timeless_mozdev.org/mozilla-central-mq/file/default/ i'm not quite sure what proof you want. but give me an airline ticket to your location and i'll gladly show you whatever proof you request.
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c40128a92338
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•13 years ago
|
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in
before you can comment on or make changes to this bug.
Description
•