577927 - Adjust appearance of Doorhanger notification pop-up to match mockups

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; sk; rv:2.0b2pre) Gecko/20100710 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; sk; rv:2.0b2pre) Gecko/20100710 Minefield/4.0b2pre

Currently is Doorhanger using rectangle with no specific styling for each platform. We need to change it for Windows, Linux and Mac.

See URL for mockups.

Reproducible: Always

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

As soon as the blocker bug 554937 is resolved we need to start work on this.

Comment 2

[Dietrich Ayala (:dietrich)]

Blocking because it blocks a blocker.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Leaving this as a blocker for now, but the course of action isn't exactly clear, beyond the bug on arrow panels.

The other dependencies all just seem to be tracking bugs. It would be great if for each of those we could get:

 - the list of essential changes to make
 - the list of nice to have changes to make

Comment 4

[Peter Henkel [:Terepin]]

This was originally meta bug, but someone changed that. (And I have absolutely no idea why.)

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

> but someone changed that

I wanted to be able to pick up blocking.  Also this is more a defined set of changes than a bug for other people to attach anything related that they find to.

>- the list of essential changes to make

We are looking for getting these to match the mockups that Stephen created.  He can provide image files.  For XP/Linux/OS X this is very straightforward.  Windows 7 is a bit more complex (with the glass border we may need bug 578780 for the arrow).  We can go with more generic graphics for modern windows for now, and deal with that in follow up bugs if we are able to get the glass color.

Comment 6

[Peter Henkel [:Terepin]]

Alex, I'm about to split Windows styling to 7/Vista (Aero Glass) and XP/Classic. The two questions I have are: Which styling will be using Aero Basic? Will be XP and Classic using the same style?

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

At the moment we can only style between default/classic until we get bug 543910 completed.

Comment 8

[Dão Gottwald [:dao]]

We can differentiate between Glass, Basic and Classic.

Comment 9

[Peter Henkel [:Terepin]]

Meta bug can have owner?

Comment 10

[:Margaret Leibovic]

(In reply to comment #9)
> Meta bug can have owner?

I don't know, but I decided to take it since I own most of the bugs it's tracking, and I'll probably work on any new things that pop up related to this bug.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #10)
> (In reply to comment #9)
> > Meta bug can have owner?

Should be shorlander.

Comment 12

[antistress]

I don't know it it should be reported here or under Bug 572482 ([Linux] UI Refresh) but current nigthly on Linux still don't have the anchor marker ("diamond" edge)which reduce the benefit of the change for doorhanger

Comment 13

[:Margaret Leibovic]

(In reply to comment #12)
> I don't know it it should be reported here or under Bug 572482 ([Linux] UI
> Refresh) but current nigthly on Linux still don't have the anchor marker
> ("diamond" edge)which reduce the benefit of the change for doorhanger

Unfortunately there were some issues with implementing arrow panels for linux, so we're still waiting on that fix. See bug 604257.

Comment 14

[Peter Henkel [:Terepin]]

Margaret, I thought you were saying DH positioning will be fixed in this bugs. But Aero DH is misplaced.

Comment 15

[:Margaret Leibovic]

(In reply to comment #14)
> Margaret, I thought you were saying DH positioning will be fixed in this bugs.
> But Aero DH is misplaced.

The patch for that hasn't landed yet. See bug 577928.

Comment 16

[Peter Henkel [:Terepin]]

Imposible, I have Aero Glass DH.

Comment 17

[Peter Henkel [:Terepin]]

DAMN! My bad, I mistaked it with styling *inside* DH.

Sorry, Margaret.

Comment 18

[Dão Gottwald [:dao]]

This bug isn't clearly scoped and the referenced mockup is very much outdated.