Closed Bug 578114 Opened 14 years ago Closed 3 years ago

[D2D][Once again not the bug you're looking for] REFTEST TEST-UNEXPECTED-PASS | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: armenzg, Assigned: bas.schouten)

References

Details

(Whiteboard: [win7][d2d][test disabled])

Attachments

(2 files)

log
26.20 KB, text/plain
Details
random-if
1.09 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
Attached file log — 
After enabling reftests for Direct 2D we are hitting this failure in this test suite.
Attachment #456893 - Attachment mime type: application/octet-stream → text/plain
I think this the same as bug 578116, which has more analysis.
Depends on: 578116
Blocks: 438871
Whiteboard: [win7][d2d] → [win7][d2d][orange]
Argh, everything from comment 2 up to here is actually a different bug from this.  Note that this bug is filed for a D2D-specific issue, and all the logs since comment 2 are non-D2D (you can tell because of the "-opt-u-reftest" in the test filename, rather than "opt-u-reftest-d2d")

Sorry for starting the cascade of spam.

This bug here is d2d-specific, and it's characterized by a 48px mismatch around the happy face's nose.  The non-D2D bug (the logs since comment 2) have only a 4px mismatch (based on just one of the logs -- haven't looked at all of them), and the mismatching pixels are at various points in the page's "blank space".

Filing a new bug for the non-D2D issue...
Filed Bug 579548 for the non-D2D issue here (comment 2 thru 8).

For now (until win7+D2D is un-hidden on the tbpl page), any failures in this test on win7 that show up on tbpl should be noted on Bug 579548, not here.
Summary: REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top → [D2D] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top
Component: Tracking → Layout
QA Contact: chofmann → layout
Version: unspecified → Trunk
Assignee: nobody → jmuizelaar
Comments 10 through 15 are all non-d2d and are hence all Bug 579548, not this bug.
Comment 17 and 18 are also Bug 579548. /me updates summary to make this bug less inviting.
Summary: [D2D] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top → [D2D][Probably not the bug you're looking for] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top
Seems like this just caused by rasterization differences with direct2d.
Switching the summary, now that non-D2D is what you won't ever be seeing.
Summary: [D2D][Probably not the bug you're looking for] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top → [D2D][Probably the bug you're looking for] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top
Well, and I guess I could have shown I was paying minimal attention by switching the nature of what's UNEXPECTED, since the problem is that we expect it to fail if(d2d), but it doesn't always fail for debug Win7, only sometimes.
Summary: [D2D][Probably the bug you're looking for] REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top → [D2D][Probably the bug you're looking for] REFTEST TEST-UNEXPECTED-PASS | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top
Assignee: jmuizelaar → bas.schouten
Attached patch random-if — — Splinter Review 
I don't think we're learning anything by letting the random passes be unexpected, and I'm pretty sure that the annotation pointing to a stale bug about multiple failures which no longer exist isn't helping.
Attachment #499783 - Flags: review?(bas.schouten)
Comment on attachment 499783 [details] [diff] [review]
random-if

Sounds good to me.
Attachment #499783 - Flags: review?(bas.schouten) → review+
Whiteboard: [win7][d2d][orange] → [win7][d2d][orange][test disabled]
Whiteboard: [win7][d2d][orange][test disabled] → [win7][d2d][test disabled]
Keywords: intermittent-failure
Summary: [D2D][Probably the bug you're looking for] REFTEST TEST-UNEXPECTED-PASS | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top → [D2D][Once again not the bug you're looking for] REFTEST TEST-UNEXPECTED-PASS | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: