578614 - tab context menu should not appear when right-clicking new tab button or the space to its right

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch v1 (show toolbar context menu instead)

Actual Results:

When right-clicking the (non-overflow) new tab button or the space to its right, the tab context menu currently appears.
This is misleading, since most of the actions in the tab context menu then apply to the selected tab, which is neither the new tab button nor empty space.

Expected Results:

The toolbar context menu should appear for easy customization.
(Even having nothing appear would be acceptable.)

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/95c013f6c962

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre

Can we get an automated test for that change?

Comment 3

[Frank Yan (:fryn)]

(In reply to comment #2)
> Can we get an automated test for that change?

When I have time, I'll put one together after bug 576345 gets fixed too.

Comment 4

[klonos]

Please rethink this one. No context at all is a bad idea. There are some commands that apply to all tabs like 'Close All Tabs', 'Reload All Tabs', 'Save All Tabs' and 'Bookmark All Tabs'.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If you wanna see that addressed please file a new bug.

Comment 7

[klonos]

(In reply to comment #5)
> If you wanna see that addressed please file a new bug.

Fair enough! Filed Bug 581646

Comment 8

[:Gavin Sharp [email: [e-mail]]]

This really should have gotten ui-review...