578779 - Hook up search

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

We need to hook up search on http://mdn.staging.mozilla.com/en-US; currently, entering a term like "rocket" and pressing Search results in http://mdn.staging.mozilla.com/en-US/?q=rocket#, but that doesn't do anything.

Comment 1

[Fred Wenzel [:wenzel]]

Fixed in bug 578191.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Jay: it's expected (for now) that it simply searches MDN, right?

Comment 3

[Jay Patel [:jay]]

For now, yes... but I hope that Fred is able to setup the Google site search that will allow us to search both the new static pages AND Deki.  I'm assuming Google search will be better than the Deki search, but I will let Sheppy chime in when he gets back next week.

Fred: When you implement the Docs page search for documents + filter and the site search, can you also update the search for all the other pages with whatever solution we decide on?  What do you think is our best bet?  Deki or Google?

I know eventually we are going to switch to whatever search library is used by the Django app stuff... but for now, we need to get search working as best as possible.

Will Google site search also improve our search quality score in any way?

Comment 4

[Jay Patel [:jay]]

reopening so we can have a discussion about what is the best approach.

Comment 5

[Fred Wenzel [:wenzel]]

Both site search and docs search are hooked up to Google AJAX search now, with a fallback to a regular Google site search if JS is disabled.

http://github.com/fwenzel/mdn/commit/23fc2af

Comment 6

[Eric Shepherd [:sheppy]]

Hey, is there any chance implementing this broke MDC's search? Because if you do any searches on MDC, you get an error claiming your search term needs to be escaped. See bug 582199.

Comment 7

[Fred Wenzel [:wenzel]]

This has really nothing to do with MDC's search being broken? Let's fix the other bug over there.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; search is hooked up, and needs CSS loving, but I think Craig's working on that.