Closed
Bug 578817
Opened 14 years ago
Closed 12 years ago
Drop download.old.js
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: abuchanan, Unassigned)
Details
Attachments
(1 file)
2.60 KB,
patch
|
clouserw
:
feedback+
|
Details | Diff | Splinter Review |
It's time this file goes bye bye, to be replaced with download.js I did a quick test, and it seems replacing old-style download buttons is fairly straightforward (I'll post a sample patch soon). A few tweaks are needed * Tweak product-details so that download button style matches what is currently on mozilla.com/en-US/. The changes are very minor. Pascal, this would affect mozilla-europe download buttons, and in fact anyone using product-details (hopefully you agree it makes them look nicer) * Look for edge cases implemented in download.old but not download.js. I'm thinking of edge cases like this... // Special case for Opera on OS X emulating IE (bug 402113) if ((navigator.userAgent.indexOf("Opera") != -1) && (navigator.userAgent.indexOf("Opera 6") == -1)) { gPlatform = PLATFORM_MACOSX; }
Reporter | ||
Comment 1•14 years ago
|
||
Attachment #457400 -
Flags: review?(pascalc)
Attachment #457400 -
Flags: feedback?(clouserw)
Reporter | ||
Comment 2•14 years ago
|
||
Oh, another tweak to do: * add the '10.4 and above' part for Mac OS X (fix for bug 439792)
Comment 3•14 years ago
|
||
Comment on attachment 457400 [details] [diff] [review] sample patch for removing download.old from en-US home page conceptually, it looks fine to me :)
Attachment #457400 -
Flags: feedback?(clouserw) → feedback+
Comment 4•14 years ago
|
||
fyi, I am working on making an l10n version of the firefox 4beta page and download.old.js is used there.
Assignee | ||
Updated•12 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Comment 5•12 years ago
|
||
Closing old Mozilla.org website bugs due to them not being relevant to the new Python-based Bedrock system. Re-open if this is a critical bug and should be resolved on the new system too.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Comment 6•12 years ago
|
||
Alex, did this get fixed?
Updated•12 years ago
|
Attachment #457400 -
Flags: review?(pascalc)
Assignee | ||
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•