Closed
Bug 578835
Opened 14 years ago
Closed 14 years ago
wipeServer doesn't deal well with failure
Categories
(Firefox :: Sync, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mconnor, Assigned: philikon)
References
Details
Attachments
(1 file, 1 obsolete file)
|
10.12 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Need to: a) stop looping on failures b) throw so sync aborts and we do the proper wipe later
Flags: blocking-fx-sync1.5+
|
Assignee | |
Comment 1•14 years ago
|
||
This patch makes wipeServer() abort if it encounters a server error (anything other than 200 or 404) and throw an exception. We also no longer catch any exceptions wipeServer() throws but let them bubble up to the callers. All callers, direct or indirect, have a this._catch() wrapper of their own but should really fail if wipeServer() fails.
Assignee: nobody → philipp
Attachment #457552 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Updated test to not leak (as discussed in bug 583949). No code changes.
Attachment #457552 -
Attachment is obsolete: true
Attachment #463164 -
Flags: review?(mconnor)
Attachment #457552 -
Flags: review?(mconnor)
|
Reporter | |
Updated•14 years ago
|
Attachment #463164 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
1.4.x: http://hg.mozilla.org/services/fx-sync/rev/a4fb3c8e8549 default: http://hg.mozilla.org/services/fx-sync/rev/570d035184ce
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•