Closed
Bug 578859
Opened 14 years ago
Closed 13 years ago
[exit] mozmill should shut down firefox if it fails to connect to jsbridge
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Assigned: k0scist)
References
Details
(Whiteboard: [mozmill-2.0+])
Attachments
(1 file)
|
726 bytes,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
currently, mozmill uses mozrunner to start firefox then attempts to wait_and_create the jsbridge network. if the latter fails, firefox is still running. instead, mozmill should shut it down
|
||
Comment 1•14 years ago
|
||
See also bug 510960
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [mozmill-2.0?]
|
|
Assignee | |
Updated•14 years ago
|
Summary: mozmill should shut down firefox if it fails to connect to jsbridge → [exit] mozmill should shut down firefox if it fails to connect to jsbridge
|
|
Assignee | |
Comment 2•13 years ago
|
||
Reproduction steps: 1. invoke (e.g.) `mozmill -m /home/jhammel/mozilla/src/mozilla-central/testing/mozmill/tests/firefox/manifest.ini --show-all` 2. before the tests can run, press ctrl+c or equivalent mozmill will quit but firefox will hang. This was fixed for 1.5.2, but evidently never ported to 2.0
Assignee: nobody → jhammel
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
|
|
Assignee | |
Comment 3•13 years ago
|
||
Turns out this was probably already fixed for 90+% of exceptions in the wild. This will additionally fix it for exceptions that don't inherent from base exceptions and additionally not (mistakely) reraise the exception until after the results reporting gets done
Attachment #508904 -
Flags: review?(fayearthur+bugs)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 508904 [details] [diff] [review] mozmill should shut down firefox if it fails to connect to jsbridge lg
Attachment #508904 -
Flags: review?(fayearthur+bugs) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
push to master as https://github.com/mozautomation/mozmill/commit/321541d9adb947339c4f1ad0cff14cb4649e4145
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•