579707 - Hard-coded strings need to be replaced with entities

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Comment 1

[Francesco Lodolo [:flod]]

Sorry, the bug was submitted by mistake without a description (how is this possible?)

In the current version, there are hardcoded strings.

extension/content/all-studies-window.xul
"Data Submission" and "Notifications" are hardcoded

extension/content/feedback-browser.xul
menuitem id="feedback-menu-show-studies" has an hardcoded "..." in the label (label="&testpilot.settings.notifyMeWhen.label;...")

Extension's description should be also made localizable
https://developer.mozilla.org/en/localizing_extension_descriptions

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Fix (partially or completely) hard-coded strings, add default pref to make description localizable

Since this bug has fallen out of radar for more than two weeks and lost the b3 train, let's try a self-made patch (not sure this is the right way, never worked before on more than one file).

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 462740 [details] [diff] [review]
Fix (partially or completely) hard-coded strings, add default pref to make description localizable

I'm not totally sold on the ellipsis use, but from a technical point of view, this is what a multi-file patch looks like :-)

Comment 4

[Francesco Lodolo [:flod]]

(In reply to comment #3)
> I'm not totally sold on the ellipsis use

Me neither. Besides, the current version uses the same "Notify me when" string twice, one with an hard-coded trailing "…" and one without.

Comment 5

[Jono Xia]

Hi Flod,
Sorry for letting this go unfixed so long.  It wasn't really "fallen off the radar" so much as I've been overloaded with other stuff.

Thank you very, very much for writing this patch!  I really appreciate it.  The patch looks fine to me.  The unicode ellipsis character literals match what we're already using in main.properties (at the request of the l10n team!) so I think that's the right thing to do.

I imported the patch to the Test Pilot Hg repo in http://hg.mozilla.org/labs/testpilot/rev/343335b8ee8d .  It still needs to be approved for inclusion in Firefox 4 beta 4.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to comment #5)
> It still needs to be approved for inclusion in Firefox 4 beta 4.

How does it work? Should I ask for approval to someone else? We're approaching the code freeze for b4 and I'd really like to see this fixed.

Comment 7

[Jono Xia]

Hi Flod,
I've asked the Firefox team to review it.  You don't need to do anything else.
Thanks!

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 462740 [details] [diff] [review]
Fix (partially or completely) hard-coded strings, add default pref to make description localizable

Though the locale entities need to be aligned properly.

Comment 9

[Francesco Lodolo [:flod]]

Attachment: Patch with locale entities properly aligned

Dave, is this ok? I never realized that .dtd and .properties files use spaces instead of tabulations.

Comment 10

[Dave Townsend [:mossop]]

Attachment: patch for mozilla-central

Comment 11

[[e-mail]]

http://hg.mozilla.org/projects/electrolysis/rev/1a841e176c6c

Comment 12

[Francesco Lodolo [:flod]]

http://hg.mozilla.org/mozilla-central/rev/1a841e176c6c