Closed Bug 579796 Opened 14 years ago Closed 2 years ago

warning: deprecated conversion from string constant to 'char*' in nsPop3Protocol

Categories

(MailNews Core :: Networking: POP, defect)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: timeless, Assigned: timeless)

Details

(Whiteboard: [patchlove])

Attachments

(1 file)

mailnews/local/src/nsPop3Protocol.cpp:
 In member function ‘PRInt32 nsPop3Protocol::GetXtndXlstMsgid(nsIInputStream*, PRUint32)’:
2678: warning: deprecated conversion from string constant to ‘char*’
 In member function ‘PRInt32 nsPop3Protocol::GetUidlList(nsIInputStream*, PRUint32)’:
2793: warning: deprecated conversion from string constant to ‘char*’
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #458224 - Flags: review?(bienvenu)
Comment on attachment 458224 [details] [diff] [review]
patch

this leaves m_pop3ConData->msg_info[i].uidl as null instead of pointing to an empty string which is treated differently in the code. I don't know that it would cause problems, or if this error actually happens in the wild any more, but I'd hate for a warning fix to cause a regression.
Attachment #458224 - Flags: review?(bienvenu) → review-
Whiteboard: [patchlove]
Severity: normal → S3

Should no longer be an issue

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: