579831 - Size of 'default' theme is not correct.

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Alfred Kayser]

In the Addons manager the size of the theme is shown (since bug 553492 is fixed), but the size of the default theme is NOT correct (12.3KB?)
If size is really a factor to compare with non-default themes, the size of the default theme should also be correctly reported.

Note, this may be a challenge as the default theme is spread over and hidden in multiple jarfiles (such as browser.jar and toolkit.jar).

Comment 1

[Dave Townsend [:mossop]]

This is quite a challenge to get right, the only way I guess would be to hardcode support for it to check the size of classic.jar (though that may well be going away anyway). I tend to think that since the default theme is uninstallable the size doesn't really matter so much and maybe it should just be hidden.

Comment 2

[Tony Mechelynck [:tonymec]]

(In reply to comment #1)
> This is quite a challenge to get right, the only way I guess would be to
> hardcode support for it to check the size of classic.jar (though that may well
> be going away anyway). I tend to think that since the default theme is
> uninstallable the size doesn't really matter so much and maybe it should just
> be hidden.

I suppose you mean the default theme is _not_ uninstallable (i.e. cannot be uninstalled). Maybe the way to go would be to show its size as zero, to mean you win zero bytes if you try to remove it?

Comment 3

[Alfred Kayser]

Zero, or 12.3KB, or 1byte are all NOT correct. 
If the size cannot be measured, that should be displayed: Not available, or Not Applicable? 
If the size of an extension and/or theme is relevant, and it seems to be so, as one can sort on it, the default theme must also display its size. Size of a theme is relevant for the performance of a browser (a smaller theme can be faster than the default theme).

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Zero, or 12.3KB, or 1byte are all NOT correct. 
> If the size cannot be measured, that should be displayed: Not available, or Not
> Applicable? 
> If the size of an extension and/or theme is relevant, and it seems to be so, as
> one can sort on it, the default theme must also display its size. Size of a
> theme is relevant for the performance of a browser (a smaller theme can be
> faster than the default theme).

I would generally disagree that the filesize of a theme has a direct correlation to the performance of the browser.

Comment 5

[Andy McKay]

The size of the theme is not shown anymore and the with heavy weight themes no longer supported in Firefox 57, closing.