Closed
Bug 579864
Opened 14 years ago
Closed 14 years ago
Make SDK compiler detection more reliable
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
908 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The current script assumes that you've installed the compiler. We should check the actual subkey that shows that it's installed.
Assignee | ||
Comment 1•14 years ago
|
||
I noticed this because mozillabuild couldn't correctly find my compiler after I had upgraded to the Vista SDK 6.0A. (In the meantime I worked around the problem by creating a junction point back to the actual install location). I should try installing the Windows 7 SDK compiler (VC9SP1EXPRESS) to see if I can write detection for it too.
Attachment #458308 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 2•14 years ago
|
||
Unlike the Vista SDK, the Windows 7 SDK puts the 32-bit compiler in the same place that VS2008 Express does, but instead of providing amd64\vcvarsamd64.bat (which I assume is provided by VS2008 Professional) it provides a choice of either vcvars64.bat (which is a true 64-bit compiler) or vcvarsx86_amd64.bat (which is a 32-bit compiler that produces 64-bit executables).
Updated•14 years ago
|
Attachment #458308 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Assignee: nobody → neil
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 3•14 years ago
|
||
Pushed with wrong bug number in comment: http://hg.mozilla.org/mozilla-build/rev/fb0a68519dcc
Updated•1 year ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•