580001 - Close console after completion causes error "inputValue is undefined"

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Viereck]

This is a follow up bug of bug 568649.

Taken from bug 568649:

> I'm getting some errors after executing some text (with tab-completion) on 
the console.
>
> 10:06 < robcee> Error: inputValue is undefined
> 10:06 < robcee> Source File: resource://gre/modules/HUDService.jsm
> 10:06 < robcee> Line: 2683

Addition: This error only happens when you did some completion and then close 
the console again.

Comment 1

[Julian Viereck]

Attachment: Patch

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 458411 [details] [diff] [review]
Patch

Needs a test

Comment 3

[Johnathan Nightingale [:johnath]]

We shouldn't spew errors. blocking final. Let's get the test and get this landed.

Comment 4

[Julian Viereck]

Attachment: Patch with tests

Comment 5

[David Dahl :ddahl]

Comment on attachment 462338 [details] [diff] [review]
Patch with tests

I think this is ok, but you may want to combine this patch with however we fix the "tab" with no input bug 583816

Comment 6

[Julian Viereck]

(In reply to comment #5)
> Comment on attachment 462338 [details] [diff] [review]
> Patch with tests
> 
> I think this is ok, but you may want to combine this patch with however we fix
> the "tab" with no input bug 583816

This bug is not related to 583816. The error described here takes place when you close the WebConsole using the key combo CMD_SHIFT_K. Whatway we fix the "tab" focus issue, the issue with closing the WebConsole still exists, I think.

Comment 7

[David Dahl :ddahl]

(In reply to comment #6)
> This bug is not related to 583816. The error described here takes place when
> you close the WebConsole using the key combo CMD_SHIFT_K. Whatway we fix the
> "tab" focus issue, the issue with closing the WebConsole still exists, I think.

Ah, ok! it is getting hard to keep track of some of these things now:)

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 462338 [details] [diff] [review]
Patch with tests

>diff --git a/toolkit/components/console/hudservice/HUDService.jsm b/toolkit/components/console/hudservice/HUDService.jsm

>   complete: function JSTF_complete(type)

>     let inputValue = inputNode.value;
>+    // If the inputNode has no value, then don't try to complete on it.
>+    if (!inputNode.value) {

Check inputValue instead? The test is kind of cheesy (we should really be looking to never throw at all, not just in that specific case!), but I suppose it doesn't hurt.

Comment 9

[Julian Viereck]

Attachment: [checked-in] Improved patch

This patch is improved based on Gavin's feedback. I've also added my name + email to the license body.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 463180 [details] [diff] [review]
[checked-in] Improved patch

http://hg.mozilla.org/mozilla-central/rev/aff7615b9d2c