Closed Bug 580406 Opened 14 years ago Closed 14 years ago

[OOOP] plugin process should be properly named

Categories

(Core :: IPC, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b3
Tracking Status
blocking2.0 --- final+

People

(Reporter: danne.da, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b2pre) Gecko/20100720 Minefield/4.0b2pre
Build Identifier: 

With the landing of bug 557225 the plugin process shows up as Minefield Software Update as defined in InfoPlist.strings in plugin-process.app/Contents/Resources/English.lproj. This should be changed to say that it is the plugin process.

Reproducible: Always
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Nominating to get this on the radar since it could be potentially very confusing.
blocking2.0: --- → ?
Not saying we shouldn't fix this, but why would this matter to anybody but the most hard-core hackers? You can't get to this bundle from the Finder, and it doesn't show up in the dock, so AFAICT it's basically an invisible string.
(In reply to comment #2)
> Not saying we shouldn't fix this, but why would this matter to anybody but the
> most hard-core hackers? You can't get to this bundle from the Finder, and it
> doesn't show up in the dock, so AFAICT it's basically an invisible string.

It shows up in Activity Monitor where people will look to check on processor and memory usage.  That's where I saw it today and I thought that the updater had an issue so I quit Minefield and restarted only to find it reappear.  Eventually I found this bug and realized that the process had nothing to do with the updater and was just the name of the plugin container.
It's just this string right here:
http://mxr.mozilla.org/mozilla-central/source/ipc/app/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in

I thought I fixed that in my patch, but I guess it must have slipped by.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #459022 - Flags: review?
Attachment #459022 - Flags: review? → review?(benjamin)
Attachment #459022 - Flags: review?(benjamin) → review+
Attachment #459022 - Flags: approval2.0?
Comment on attachment 459022 [details] [diff] [review]
Patch (v1)

a=beltzner
Attachment #459022 - Flags: approval2.0? → approval2.0+
blocking2.0: ? → final+
http://hg.mozilla.org/mozilla-central/rev/bbb4fcc2b012
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: