Closed Bug 580413 Opened 14 years ago Closed 14 years ago

Download source "unknown" is listed as "null" in /addon/2257/statistics/sources-month-20100101-20100507.csv

Categories

(addons.mozilla.org Graveyard :: Statistics, defect, P5)

defect

Tracking

(Not tracked)

VERIFIED FIXED
5.12.3

People

(Reporter: krupa.mozbugs, Assigned: potch)

References

()

Details

(Whiteboard: [z])

Attachments

(3 files)

steps to reproduce:

1. Go to https://next.addons.mozilla.org/z/en-US/firefox/addon/2257/statistics/sources-month-20100101-20100507.csv
2. Notice the download sources listed

observed behavior:
One of the listed download source is "null". This should probably be changed to "unknown"

(Unknown is a download source available in remora)
Target Milestone: --- → 5.11.6
Target Milestone: 5.11.6 → 5.11.7
I'll look at what this should be doing in 5.11.8
Assignee: thepotch → clouserw
Target Milestone: 5.11.7 → 5.11.8
Daniel:  I'm looking at the data for this add-on in the database and I see:

a:15:{s:6:"search";i:739;s:18:"similarcollections";i:2;s:10:"developers";i:3;s:11:"recommended";i:1720;s:9:"creatured";i:128;s:13:"oftenusedwith";i:1;s:3:"api";i:9995;s:10:"collection";i:123;s:4:"null";i:364;s:14:"homepagebrowse";i:669;s:11:"addondetail";i:2344;s:8:"category";i:379;s:13:"homepagepromo";i:83;s:10:"sharingapi";i:1;s:11:"userprofile";i:8;}


is "null" the total of unknown sources or is it something else?
Those are requests which have no src= parameter at all.  If you'd like us to put something else in rather than null it can be done.  Don't believe it was ever part of the spec so we just left it with the default behavior.
Great, thanks.  This bug as it stands is a WONTFIX then.  I'm assigning this to potch though so we can make the front end say "Unknown"
Assignee: clouserw → chowse
Assignee: chowse → thepotch
Priority: -- → P5
Target Milestone: 5.11.8 → 5.12
Target Milestone: 5.12 → 5.12.1
Target Milestone: 5.12.1 → 5.12.2
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This is not fixed under "Download sources by Date". See attached screenshot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached image screenshot
Target Milestone: 5.12.2 → 5.12.3
http://github.com/jbalogh/zamboni/commit/3fdd571
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
There is still a mention of "null" at https://addons.allizom.org/z/en-US/firefox/addon/2257/statistics/sources-day-20100813-20101111.csv mentioned in comment 0.

reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached image screenshot-11/11
Despite the title, this bug doesn't cover fixing the CSVs, just the frontend.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
I think the CSVs and "null" are fine
Attached image post-fix screenshot
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: