Closed
Bug 580413
Opened 14 years ago
Closed 14 years ago
Download source "unknown" is listed as "null" in /addon/2257/statistics/sources-month-20100101-20100507.csv
Categories
(addons.mozilla.org Graveyard :: Statistics, defect, P5)
Tracking
(Not tracked)
VERIFIED
FIXED
5.12.3
People
(Reporter: krupa.mozbugs, Assigned: potch)
References
()
Details
(Whiteboard: [z])
Attachments
(3 files)
steps to reproduce: 1. Go to https://next.addons.mozilla.org/z/en-US/firefox/addon/2257/statistics/sources-month-20100101-20100507.csv 2. Notice the download sources listed observed behavior: One of the listed download source is "null". This should probably be changed to "unknown" (Unknown is a download source available in remora)
Updated•14 years ago
|
Target Milestone: --- → 5.11.6
Updated•14 years ago
|
Target Milestone: 5.11.6 → 5.11.7
Comment 1•14 years ago
|
||
I'll look at what this should be doing in 5.11.8
Assignee: thepotch → clouserw
Target Milestone: 5.11.7 → 5.11.8
Comment 2•14 years ago
|
||
Daniel: I'm looking at the data for this add-on in the database and I see: a:15:{s:6:"search";i:739;s:18:"similarcollections";i:2;s:10:"developers";i:3;s:11:"recommended";i:1720;s:9:"creatured";i:128;s:13:"oftenusedwith";i:1;s:3:"api";i:9995;s:10:"collection";i:123;s:4:"null";i:364;s:14:"homepagebrowse";i:669;s:11:"addondetail";i:2344;s:8:"category";i:379;s:13:"homepagepromo";i:83;s:10:"sharingapi";i:1;s:11:"userprofile";i:8;} is "null" the total of unknown sources or is it something else?
Comment 3•14 years ago
|
||
Those are requests which have no src= parameter at all. If you'd like us to put something else in rather than null it can be done. Don't believe it was ever part of the spec so we just left it with the default behavior.
Comment 4•14 years ago
|
||
Great, thanks. This bug as it stands is a WONTFIX then. I'm assigning this to potch though so we can make the front end say "Unknown"
Assignee: clouserw → chowse
Updated•14 years ago
|
Assignee: chowse → thepotch
Updated•14 years ago
|
Priority: -- → P5
Updated•14 years ago
|
Target Milestone: 5.11.8 → 5.12
Updated•14 years ago
|
Target Milestone: 5.12 → 5.12.1
Assignee | ||
Updated•14 years ago
|
Target Milestone: 5.12.1 → 5.12.2
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•14 years ago
|
||
This is not fixed under "Download sources by Date". See attached screenshot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 6•14 years ago
|
||
Updated•14 years ago
|
Target Milestone: 5.12.2 → 5.12.3
Assignee | ||
Comment 7•14 years ago
|
||
http://github.com/jbalogh/zamboni/commit/3fdd571
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•14 years ago
|
||
There is still a mention of "null" at https://addons.allizom.org/z/en-US/firefox/addon/2257/statistics/sources-day-20100813-20101111.csv mentioned in comment 0. reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 9•14 years ago
|
||
Assignee | ||
Comment 10•14 years ago
|
||
Despite the title, this bug doesn't cover fixing the CSVs, just the frontend.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 11•14 years ago
|
||
I think the CSVs and "null" are fine
Reporter | ||
Comment 12•14 years ago
|
||
verified @ https://addons.allizom.org/z/en-US/firefox/addon/2257/statistics/downloads/sources/#last=90
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 13•14 years ago
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•