580901 - Directly call loadOneTab instead of Tabs.open

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ed Lee :Mardak]

Can also avoid making use of the wrapped tab tab.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/1832de5a5a95
Remove Tabs.open and BrowserWindow.addTab and directly deal with xul tabs.

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 459323 [details] [diff] [review]
v1

Looks good. One comment: you're using "let" instead of "var" at one point; I thought we had settled to stick with var?

Comment 4

[Ed Lee :Mardak]

Oh, I guess we can switch it back to var. But "let is the new var" ;) Most new code in firefox is using let I believe.

Comment 5

[Ian Gilman [:iangilman]]

(In reply to comment #4)
> Oh, I guess we can switch it back to var. But "let is the new var" ;) Most new
> code in firefox is using let I believe.

Just discussed it with mitcho and gavin. Gavin's recommendation is to leave all the existing vars but use let for all new code. Sounds good to me.

Comment 6

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".