580965 - Vertical lines between non-tab tab bar elements look out of place in the tabs on top mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Henri Sivonen (:hsivonen)]

Attachment: Screenshot of the lines that don't look quite right

Steps to reproduce:
 1) Use a Mac
 2) Update to nightly from around 2010-07-21
 3) Make sure "tabs on top" is enabled.

Actual results:
In the right, the three non-tab UI elements are bounded by vertical lines that end sharply at the title bar. The lines don't look right for unified windows, since unified windows generally don't have elements that end sharply at the title bar.

Expected results:
Expected these UI elements not to have the lines around them or, alternatively, expected the lines to fade gradually upwards to make the transition to the title bar look less sharp.

Comment 2

[Markus Stange [:mstange]]

Stephen, did the summary change in bug 594016 mean that we should remove the separators in tabs-on-bottom mode, too?

Comment 3

[Stephen Horlander [:shorlander]]

(In reply to comment #2)
> Stephen, did the summary change in bug 594016 mean that we should remove the
> separators in tabs-on-bottom mode, too?

Yes, I think we can remove these in both configurations.

Comment 4

[Markus Stange [:mstange]]

Attachment: v1

Comment 5

[Markus Stange [:mstange]]

Attachment: screenshot, tabs on top

Comment 6

[Markus Stange [:mstange]]

Attachment: screenshot, tabs on bottom

Comment 7

[Stephen Horlander [:shorlander]]

Comment on attachment 494139 [details]
screenshot, tabs on bottom

Looks good, thank you! We might want to reduce the space between them but if so I will file a follow-up.

Comment 8

[Markus Stange [:mstange]]

Attachment: for checkin

Comment 9

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/49a1b2aa43c5

Comment 10

[Dominic Spitaler]

may I say that the new pressed/hover states for those elements now looks kind of strange…

Comment 11

[Stephen Horlander [:shorlander]]

(In reply to comment #10)
> may I say that the new pressed/hover states for those elements now looks kind
> of strange…

I agree it looks strange now. I will file a followup bug.

Comment 12

[Markus Stange [:mstange]]

The inner shadow in the pressed state wasn't an intentional change and is not from this bug; it's only there because of unintentional selector specificity change and will be fixed in bug 620059.