Closed
Bug 581044
Opened 14 years ago
Closed 14 years ago
Use square toolbarbuttons in the Places library window
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b4
People
(Reporter: mstange, Assigned: mstange)
Details
Attachments
(1 file, 1 obsolete file)
2.98 KB,
patch
|
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Now that the main window buttons aren't round any more, those in the Places library shouldn't be either.
Attachment #459457 -
Flags: review?(dao)
Comment 1•14 years ago
|
||
Comment on attachment 459457 [details] [diff] [review] v1 > #back-button > .toolbarbutton-icon { >+ -moz-margin-start: 3px !important; > -moz-margin-end: 2px !important; > } > > #forward-button > .toolbarbutton-icon { > -moz-margin-start: 2px !important; >+ -moz-margin-end: 3px !important; > } Please explain?
Assignee | ||
Comment 2•14 years ago
|
||
Further up, a horizontal margin of 4px is set on the toolbarbutton-icons, so this just decreases the outer margins by 1px. Now their width matches the width of the small back/forward button pair in the main browser window. (Almost, at least - the forward button in the main browser window is 1px shorter.)
Comment 3•14 years ago
|
||
Comment on attachment 459457 [details] [diff] [review] v1 > #placesToolbar > toolbarbutton { > list-style-image: url("chrome://browser/skin/places/toolbar.png"); >- margin: 4px 6px 5px; >- padding: 1px 5px; >+ margin: 4px 4px 5px; >+ padding: 1px 3px; > -moz-border-radius: 100%; remove this line
Attachment #459457 -
Flags: review?(dao) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #459457 -
Attachment is obsolete: true
Attachment #461643 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #461643 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8522bc32ad34
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•