581073 - Search pane needs to expose the relevancy sort order

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

When you start a search for add-ons, i.e. by typing "url" in the search bar and hit Return or click the magnifier glas, the results aren't sorted.

The question is if we should sort by name or rating initially. I would tend to say rating, because a couple of results don't have the search string in its name but in the description. Showing up add-ons with the highest rating first, would allow users to directly install those without scrolling too much.

Comment 1

[Dave Townsend [:mossop]]

They are being sorted by relevancy by default, which isn't terribly well exposed in the UI. We probably need to add this to the sort chooser for the search pane.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is different from the rating and comes from AMO?

Comment 3

[Dave Townsend [:mossop]]

It is based on how well the result matches the search terms and does not come from AMO

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Re-nominating for beta5 - this needs a string change.

Comment 5

[Dave Townsend [:mossop]]

So it does.

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Also removed the old sort by ratings entities left over from bug 585950.

Don't think it needs additional automated tests - since its just exposing something that was already working (and tested).

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 469423 [details] [diff] [review]
Patch v1

>diff --git a/toolkit/mozapps/extensions/content/extensions.xml b/toolkit/mozapps/extensions/content/extensions.xml
>--- a/toolkit/mozapps/extensions/content/extensions.xml
>+++ b/toolkit/mozapps/extensions/content/extensions.xml
>@@ -239,33 +239,43 @@
>     <content orient="horizontal">
>       <xul:button anonid="btn-name" class="sorter"
>                   label="&sort.name.label;" tooltiptext="&sort.name.tooltip;"
>                   oncommand="this.parentNode._handleChange('name');"/>
>       <xul:button anonid="btn-date" class="sorter"
>                   label="&sort.dateUpdated.label;"
>                   tooltiptext="&sort.dateUpdated.tooltip;"
>                   oncommand="this.parentNode._handleChange('dateUpdated');"/>
>+      <xul:button anonid="btn-relevance" class="sorter" hidden="true"
>+                  label="&sort.relevance.label;"
>+                  tooltiptext="&sort.relevance.tooltip;"
>+                  oncommand="this.parentNode._handleChange('relevancescore');"/>

Double check with Boriss whether this should go on the left or right. I kind of think that if it is going to be the default for searches then it should be the right.

>diff --git a/toolkit/mozapps/extensions/content/extensions.xul b/toolkit/mozapps/extensions/content/extensions.xul
>--- a/toolkit/mozapps/extensions/content/extensions.xul
>+++ b/toolkit/mozapps/extensions/content/extensions.xul
>@@ -210,18 +210,18 @@
>                      label="&search.filter2.installed.label;" value="local"
>                      tooltiptext="&search.filter2.installed.tooltip;"/>
>               <radio id="search-filter-remote" class="search-filter-radio"
>                      label="&search.filter2.available.label;" value="remote"
>                      tooltiptext="&search.filter2.available.tooltip;"/>
>             </radiogroup>
>           </hbox>
>           <hbox class="view-header" pack="end">
>-            <hbox id="search-sorters" class="sort-controls" sortby="name"
>-                  ascending="true"/>
>+            <hbox id="search-sorters" class="sort-controls"
>+                  showrelevance="true" sortby="name" ascending="true"/>

Should sortby default to relevance?

r+ assuming you get answers to those two from Boriss and flip accordingly.

Comment 8

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #1)
> They are being sorted by relevancy by default, which isn't terribly well
> exposed in the UI. We probably need to add this to the sort chooser for the
> search pane.

Yes, they should be ranked by relevancy by default, and one of the drop-down sorts at the top right should be "Keyword Match" (instead of "relevancy" for consistency with AMO).  The other should be "name."  The plan is to show a fixed number of results, with the final item being a link to go to AMO for complete results.  Since the results don't populate further as the user scrolls down, we should be working with a fixed & sortable set.

Tthe relevancy title in the top right should act as a button rather than a drop-down, since sorting by increasing relevancy is kind of useless.

Comment 9

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #7)
> Double check with Boriss whether this should go on the left or right. I kind of
> think that if it is going to be the default for searches then it should be the
> right.

Yes, it should go on the right.

> Should sortby default to relevance?

Yes, though the string should be "Keyword Match" to be consistent with AMO.

Comment 10

[Jennifer Morrow [:Boriss] (UX)]

Talked to Blair: though "Keyword Match" is the most consistent with AMO option,  "Best Match" is really a more appropriate string (a search term is not necessarily a keyword).  So, let's use "Best Match" and ask AMO nicely if they could change to that too.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #7)
> Should sortby default to relevance?

The search view automatically sets it to sort by relevance each time you do a search, so the default on the sorters widget is never actually used there.

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1.1 - ready for checkin

Comment 13

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/83ac11749dd7

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100829 Firefox/4.0b5pre

Is sorting covered by an automated test or should we have a manual one?

Comment 15

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Its covered by automated tests elsewhere. And I *think* there's already a manual test for the sort buttons - if not, would be good to have a manual test. Would only need to cover making sure the buttons work and look right. The order of the items in the list is already quite well tested by various automated tests - so no need to test that again. And anyway, manual testing of the relevancy order would be quite difficult, I would think.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Added Litmus test:
https://litmus.mozilla.org/show_test.cgi?id=15174