581132 - Migrate the /browse/type:x/cat:y RSS feeds

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Since you're the RSS master these days, I found another RSS feed to migrate.  Remora used super ugly URLs for it's category landing pages, and they are still in use for the RSS feeds.  Examples:

https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:72/format:rss?sort=updated

https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:4/format:rss?sort=updated

These are actually linked to from zamboni, so if you go to the associated pages you'll see <link> tags pointing to them.  Respectively:

https://preview.addons.mozilla.org/en-US/firefox/extensions/alerts-updates/

https://preview.addons.mozilla.org/en-US/firefox/extensions/web-development/

We'd like the RSS feeds to come out of zamboni with prettier URLs, say:


https://preview.addons.mozilla.org/en-US/firefox/extensions/alerts-updates/format:rss

https://preview.addons.mozilla.org/en-US/firefox/extensions/web-development/format:rss


This bug includes:
- construction of new RSS feeds at new URLs
- 301 redirects from old URLs
- Changing the <link> tags on the category landing pages to point to the new feeds

Comment 1

[Sam Keen]

Have the bulk of the code complete, still need to add the 301 and get the RSS feed to work w/ the ?sort= URI param
http://github.com/samkeen/zamboni/commit/0bdc50d1706a9316c4a4a916c28e2a5934b404ff

Comment 2

[Sam Keen]

make a few minor tweaks, my branch is now at: http://github.com/samkeen/zamboni/commit/d5b25165cdc991847580d550c61271a36e84f5da

What's left:

- How to handle 301's
   
    old URL's used ids , new uses slugs, so wouldn't be able to 301 from .../cat:72/format:rss direct to .../extensions/alerts-updates/format:rss
    Do we want to support /extensions/{cat_slug}/format:rss   and /extensions/{cat_id}/format:rss  on zamboni?


- need to extract the selection logic for the addons from browse/views.py::extensions so it can be re-used in the RSS feed (see http://github.com/samkeen/zamboni/commit/d5b25165cdc991847580d550c61271a36e84f5da#L0R50)

Comment 3

[Wil Clouser [:clouserw]]

Sounds good, let me know if you need anything from me

Comment 4

[Sam Keen]

created apps/browse/helpers.py
took the functionality the RSS feed needed from views.py and moved it to helpers.py

http://github.com/samkeen/zamboni/commit/336435360db54f150b01bbb68056aba902dbf567

Comment 5

[Sam Keen]

pushed to master
http://github.com/jbalogh/zamboni/commit/95cb0f5ac881dde56e31ea9ecbaae9f9c64440c9