Closed Bug 581592 Opened 14 years ago Closed 14 years ago

in layout/reftests/canvas/size-change-1.html, intermittent 1 or 2 ASSERTION: CanvasLayer: Updated rect bigger than bounds!: 'mUpdatedRect.IsEmpty() || mBounds.Contains(mUpdatedRect)'

Categories

(Core :: Graphics: Canvas2D, defect)

Product:
Core
Component:
Graphics: Canvas2D
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: khuey, Assigned: philor)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

For checkin
735 bytes, patch
Details | Diff | Splinter Review 
Highly suspect this is the same bug though the error is slightly different

assertion count 1 is more than expected 0 assertions
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1279930106.1279931560.27871.gz
Summary: REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-reftest/build/reftest/tests/layout/reftests/canvas/size-change-1.html | assertion count 2 is more than expected 0 assertions → REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-reftest/build/reftest/tests/layout/reftests/canvas/size-change-1.html | assertion count [1|2] is more than expected 0 assertions
For reference, the extra single assertion is:
###!!! ASSERTION: CanvasLayer: Updated rect bigger than bounds!: 'mUpdatedRect.IsEmpty() || mBounds.Contains(mUpdatedRect)', file /builds/slave/mozilla-central-macosx-debug/build/gfx/layers/basic/BasicLayers.cpp, line 734
Depends on: 591859
Attached patch Fix v.1 (obsolete) — — Splinter Review 
Not sure whether I'm not finding an example to copy other than the 10.5-only one because we don't have one, or because I don't know what the easy way to get "any Mac" is.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #470376 - Flags: review?(dbaron)
Summary: REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/mozilla-central-leopard-debug-u-reftest/build/reftest/tests/layout/reftests/canvas/size-change-1.html | assertion count [1|2] is more than expected 0 assertions → in layout/reftests/canvas/size-change-1.html, intermittent 1 or 2 ASSERTION: CanvasLayer: Updated rect bigger than bounds!: 'mUpdatedRect.IsEmpty() || mBounds.Contains(mUpdatedRect)'
Comment on attachment 470376 [details] [diff] [review]
Fix v.1

We normally write mac-specific failures as "cocoaWidget".  You're also missing a close paren.  So review- on this, but r=dbaron on "asserts-if(cocoaWidget,0-2)"
Attachment #470376 - Flags: review?(dbaron) → review-
Vlad, can we bump the assertion count here?  It doesn't seem like we're getting any useful information here.
Well, it would be interesting to know -why- that's happening.  Not sure why we'd hit that, unless we didn't create a new canvas layer when we should have (because the size changed).
I know it's a bit difficult to see with all the starring, but I do already have r+ to adjust the count, I just need tree-room to land, and I did already file bug 591859 for your quieter place to figure out what happened on July 23rd to start it happening.
Attached patch For checkin — — Splinter Review 
I'd love to claim that I botched the parens because I was concentrating so hard on getting my trychooser syntax right, but since I botched that twice too, I probably can't. This, however, works.
Attachment #470376 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/55f5cc760da7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Blocks: 438871
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: