Closed Bug 582191 Opened 14 years ago Closed 14 years ago

nanojit: fix formatImm[IQ] bogons

Categories

(Core Graveyard :: Nanojit, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(1 file)

Small integer immediates, in the range -9999..9999, are printed specially by Nanojit in the LIR dumping stages.  Except the ranges tests are broken, using '||' where they should use '&&'.  Because of this I was seeing the 64-bit immediate 0x7fffffffffff printed as -1, because it was being cast to 'int'.

The attached patch fixes this.  It also changes formatImmQ() to be defined only on 64-bit platforms.
Attachment #460481 - Flags: review?(edwsmith)
Attachment #460481 - Flags: review?(edwsmith) → review+
TR: http://hg.mozilla.org/tamarin-redux/rev/be8ddbd17a5f
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
http://hg.mozilla.org/tracemonkey/rev/ea977d4cd722
Whiteboard: fixed-in-nanojit, fixed-in-tamarin → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/ea977d4cd722
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: