Closed
Bug 582288
Opened 14 years ago
Closed 14 years ago
Clusters should not be part of the feedback Django app
Categories
(Input :: General, defect, P1)
Input
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.7
People
(Reporter: wenzel, Assigned: davedash)
References
Details
(Whiteboard: [qa-])
apps/feedback contains (mostly) stuff related to collecting feedback. Clustering has nothing to do with collecting feedback, and should probably be its own Django app.
Assignee | ||
Comment 1•14 years ago
|
||
Fair point, it's kind of grown. Originally it was a cluster of opinions which is why I started there.
Comment 2•14 years ago
|
||
Will this help us in terms of performance?
Priority: -- → P2
Target Milestone: --- → 1.7
Reporter | ||
Comment 3•14 years ago
|
||
Ryan: I think this would help you figuring out Django. What we need here is a new app under apps, named clusters. Then move all things related to the clusters part of the site (url rules, views, possibly helpers, as well as models and templates) from the feedback app to the clusters app. Presumably a few imports will need to change, and for the models, you'll have to define the Meta option [1] db_table (because the tables already exist and they are prefixed with feedback_ ). As this -- to answer Aakash's question -- won't have a performance impact, this is also not vital for 1.7, so you can take it easy. [1] http://docs.djangoproject.com/en/dev/ref/models/options/
Priority: P2 → P3
Assignee | ||
Comment 4•14 years ago
|
||
Uh... ryan if you do this, have me r? it. I created in a branch an app called "topics" and was doing the same thing. If you don't get to it by monday I will actually do this, as I need to redo the topics UX (and underlying models).
Comment 5•14 years ago
|
||
Thanks Fred. No worries Dave. If you're already working on this, then don't let me get in your way.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → dd
Updated•14 years ago
|
Priority: P3 → P1
Assignee | ||
Comment 6•14 years ago
|
||
http://github.com/fwenzel/reporter/commits/02eda48
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 7•14 years ago
|
||
Is this something QA can verify?
Assignee | ||
Updated•14 years ago
|
Whiteboard: [qa-]
Updated•13 years ago
|
Component: Input → General
Product: Webtools → Input
You need to log in
before you can comment on or make changes to this bug.
Description
•