58254 - Printing broken on Carbon

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

The MacOS printing APIs were obsoleted in Carbon. We need to rewrite printing to
use the new APIs.

Comment 1

[Mike Pinkerton (not reading bugmail)]

*** Bug 58255 has been marked as a duplicate of this bug. ***

Comment 2

[Mike Pinkerton (not reading bugmail)]

dcone, this is needed in the mozilla1.0 timeframe, OSX is a tier one platform
for the next release.

Comment 3

[shrirang khanzode]

spam : changing qa to sujay (new qa contact for Printing)

Comment 4

[Steve Dagley]

With Mozilla 0.9 being Carbonated I believe it's time to bring this bug Back From 
the Future

Comment 5

[Marcia Knous [:marcia]]

nominating for dogfood (from sdagley's list of bugs that are good candidates for 
our next release) 

Comment 6

[Mike Pinkerton (not reading bugmail)]

printing is dogfood.

Comment 7

[Patrick C. Beard]

I already did much of this work. What's missing?

Comment 8

[selmer (gone)]

dogfood+, therefore removing catfood.  What's required to complete the fix?

Comment 9

[Mike Pinkerton (not reading bugmail)]

beta stopper. printing doesn't work at all on m6y 6/5 osx build.

Comment 10

[Chris Meyer]

Probably falls under the realm of the last comment, but the 'Preview' button
doesn't work in the Print dialog either...

Comment 11

[Mike Pinkerton (not reading bugmail)]

*kick*

Comment 12

[Marek Z. Jeziorek]

Steve, this is PDT+ bug. Tomorrow, on Tuesday, we'll try to build the first RTM
candidate. It would be good, if this could be checked in ASAP.

Comment 13

[Mike Pinkerton (not reading bugmail)]

i have a fix to get it to print (dcone broke it with the print options landing, 
ahem), and a fix to a memory leak on os9 and osx (nsCOMPtr is your friend, ahem), 
but it only prints one time.

I'm doing a debug build now to figure it out. taking.

Comment 14

[Adam Masri]

*** Bug 89728 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] fix printing on osx and a leak on 9/X

Comment 16

[Mike Pinkerton (not reading bugmail)]

patch attached that fixes printing on carbon. We were leaking the devContextSpec 
on both 9 and X and that had to be fixed for carbon. When this is closed, i'll 
open a new bug for dcone to implement the print options he stubbed out for 
carbon.

needing r/sr.

Comment 17

[Simon Fraser [no longer active]]

sr=sfraser

Comment 18

[Steve Dagley]

r=sdagley

Comment 19

[Mike Pinkerton (not reading bugmail)]

fix landed on trunk and branch. we need to get some classic macos9 coverage on 
this just to be safe since i fixed a leak there that might cause code to be 
executed that wasn't being called.

Comment 20

[Mike Pinkerton (not reading bugmail)]

.

Comment 21

[Mike Pinkerton (not reading bugmail)]

bug to implement carbon print options given to dcone.

http://bugzilla.mozilla.org/show_bug.cgi?id=90751

Comment 22

[sujay]

Mike, can you please verify this one and mark VERIFIED-FIXED?

I don't have access to a machine with Mac OSX..

Also cc'ing Chris Petersen

Comment 23

[Mike Pinkerton (not reading bugmail)]

since part of the fix involves macos9, also verify that printing on os9 is ok and 
doesn't do anything weird. try printing two times just to make sure.

Comment 24

[Chris Petersen]

Marking verified in the 20010716 builds. Checked in Mac OS X 10.0.4 and OS 9.1.