582751 - list properties in leaked objects with generic toString methods

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: implements change

Leak warnings about objects with generic toString methods should list the properties in the object to make it easier to identify the objects via duck typing.

Comment 1

[Atul Varma [:atul]]

Comment on attachment 461018 [details] [diff] [review]
patch v1: implements change

Yeah, awesome!

Comment 2

[Drew Willcoxon :adw]

Attachment: print bins along with leaked objects

Not to hijack this bug, but I've used this patch to print "bin" info along with leaked objects, in case you're interested...

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: incorporates Drew's patch

I'm interested!  Here's a combined patch.

Comment 4

[Atul Varma [:atul]]

Comment on attachment 461028 [details] [diff] [review]
patch v2: incorporates Drew's patch

Fine tag-teaming.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/labs/jetpack-sdk/rev/9e28b016db36

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".