Closed Bug 583375 Opened 14 years ago Closed 14 years ago

upgrade ANGLE to r367

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: vlad, Unassigned)

Details

picks up some shader compiler fixes, as well as DEPTH24_STENCIL8 support.
http://hg.mozilla.org/mozilla-central/rev/582be9aca672
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This broke non-IPC builds as follows:

In file included from /buildbot/comm-central-trunk-bloat-linux/build/mozilla/content/canvas/src/WebGLContextGL.cpp:62:
../../../dist/include/angle/ShaderLang.h:50: error: comma at end of enumerator list
../../../dist/include/angle/ShaderLang.h:59: error: comma at end of enumerator list
../../../dist/include/angle/ShaderLang.h:69: error: comma at end of enumerator list
../../../dist/include/angle/ShaderLang.h:74: error: comma at end of enumerator list

It appears that the chromium-config.mk file disables -pedantic for IPC builds.

vlad, do you want to fix the code, or should we discuss on one of the newsgroups about the -pedantic option being enabled differently according to what we're building with?

For now, I'm going to specify --disable-pedantic in TB's tinderbox builds to get them green for the weekend.
You need to log in before you can comment on or make changes to this bug.